News for hackers. Stuff that matters.
Re:Of GitHub and Pull Requests (and comics) by yummyfajitas on Wednesday April 11, 2012 @12:14PM (#3828213)
hard to say without seeing the pull requests, but if you edit compiled code and call it a typo you're probably at risk of doing a lot of things wrong.

True - what you should do is submit a fix that takes compiled code out of the repo and replaces it with a build script.

Re:Of GitHub and Pull Requests (and comics) by technoweenie on Wednesday April 11, 2012 @03:23PM (#3829181)
That's definitely a change I'd bring up with the project first. I agree that having compiled code in there is bad, but it's typically not something a first time pull requester touches. Same goes for project files (Gemfiles, package.json, licenses, changelogs, whatever).