News for hackers. Stuff that matters.
Re: Six Apart acquires and shuts down Pownce by plinkplonk on Monday December 01, 2008 @09:35PM (#382519)
"Hers is basically a coded version of what you'd do manually, eyeballing past the decimal. She's more familiar with string conversion than ceil, floor and round. So? That merits public judgment of incompetence?"

Yes.

I am not trying to be nasty here, but code like that makes me cringe. And yes, if I saw code like that, I would make a strong presumption of programming incompetence.(which is all right. Not everyone has to be a good programmer. As pxlpusher notes above, "get it done" competence is often more valuable).

Since it was publicly posted code, I don't see a problem with "public judgment" either.

"Of being an impostor?"

No. Programming Incompetence != Being an impostor. Anyone can be genuine and incompetent in a particular skill.

Re: Six Apart acquires and shuts down Pownce by astrec on Monday December 01, 2008 @09:49PM (#382534)
Since it was publicly posted code, I don't see a problem with "public judgment" either.

So judge that code. There simply isn't enough information to presume programmer incompetence (let alone make a strong presumption).

In my experience, code reviews are humbling to one and all: Bear that in mind before you raise charges of incompetence.

Re: Six Apart acquires and shuts down Pownce by plinkplonk on Monday December 01, 2008 @09:58PM (#382544)
"In my experience, code reviews are humbling to one and all: Bear that in mind before you raise charges of incompetence."

Sure, but as someone said above

"I agree in theory, but ... converting a float to a string to compute an average?"

We'll have to agree to disagree on whether code like this indicates programmer incompetence. To me, it does. YMMV.