News for hackers. Stuff that matters.
Re:A behind-the-scenes look at Facebook release engineering by zbuc on Thursday April 05, 2012 @01:15PM (#3803531)
How do you wind up with a 1.5gb binary? That's incredible -- especially considering all their static assets are on their CDN, so this is basically their code and all the libraries they're pulling in.
Re:A behind-the-scenes look at Facebook release engineering by kmavm on Thursday April 05, 2012 @02:12PM (#3803808)
(I work on the HipHop compiler.) You start by compiling PHP source.

Simple PHP statements take a lot more space in the binary than intuition suggests. E.g.:

if ($a == $b) ...

would seem like it should be

  cmp $rax, $rbx
  jz ...
But! If type inference has failed, we don't know what types $a and $b are, so they might be strings or objects or something crazy. So we're going to have to indirectly dispatch to $a's '==' method. We also spend a ton of space on reference counting code; the semantics of the language basically force you to do naive reference counting, since refcounts can be witnessed in various ways, so every time we pass an argument, do an assignment, sometimes even evaluate expressions, we need to manipulate reference counts, and if they've gone to zero call a destructor.

It ends up making the code really large, and one of the things that's unique about our efforts to run PHP fast relative to other dynamic language efforts is that sheer code bulk ends up being our largest enemy; if we're not careful, icache misses eat us alive.

Finally, I'll note that it's not quite a 1.5GB binary. The actual ELF binary is something like 1.1GB, and the remainder of the package we bittorrent around production is stuff like static resources (javascript, css) and primed contents for the APC cache that we want prepopulated on boot.

Re:A behind-the-scenes look at Facebook release engineering by cookiecaper on Thursday April 05, 2012 @02:34PM (#3803908)
Based on your work heretofore, do you think it's wise for Facebook to continue on the PHP path instead of working on a backend rewrite in C# or some other, saner language? I find it odd that Facebook is still using PHP and pouring lots of effort and cash into things like HipHop when they're obviously hiring people smart enough to use another language, and when they obviously have the runway to perform a dark horse rewrite into a much cleaner, saner backend.
Re:A behind-the-scenes look at Facebook release engineering by kmavm on Thursday April 05, 2012 @02:49PM (#3803980)
This is a long and deep subject.

I wouldn't say that we've "continued on the PHP path." I'd say that we've refused to throw out the precious PHP parts of our application, while not being afraid to use more appropriate languages across Thrift boundaries when needed. Our search engine, newsfeed, and ad serving infrastructure, for instance, are in C++.

A drop-everything-and-rewrite of the PHP code is entirely out of the question, for all the reasons covered in Spolsky's 12-year-old classic on the subject: http://www.joelonsoftware.com/articles/fog0000000069.html. Those of us working on making PHP perform better are a tiny fraction of Facebook engineering as a whole; this small overhead cost is nothing compared to the risks inherent in a ground-up rewrite.

Most of PHP's language-level faults can be engineered around. For instance, we have a code-review-time script that parses (really parses) the code to warn engineers (and reviewers) about dangerous or deprecated idioms.

PHP also has some affirmative virtues. The programming model is more productive than that of compiled languages, and even many interpreted languages; save/reload the web page is just a better, tighter loop to get work done in than save/compile/restart my server/reload the web page. I'm actually a fan of PHP's concurrency model, which naifs often mistake as "no concurrency allowed"; PHP's concurrency primitive is curl[1], and if you wrap a tiny bit of library around it, you can make it behave like actors.

[1] Seriously. curl provides a shared-nothing way to asynchronously run code, and has the virtue of not caring what language the other side is written in to boot.

Re:A behind-the-scenes look at Facebook release engineering by cookiecaper on Thursday April 05, 2012 @04:35PM (#3804484)
Right, I'm familiar with Spolsky's piece, but I think there are times when a rewrite is legitimate. I think that a situation where you must roll a completely custom in-house compiler that generates binaries which exceed 1 GB in size in order to get adequate performance of your app is a good candidate for a new architecture, despite Spolsky's claims. Spolsky's article discusses throwing out pages of code because the programmers "don't know what half of these API calls are for" and "[wanting] to build something grand" -- these are quite different impulses than the real-world problems staring Facebook in the face by its continued usage of PHP.

I think also that there is a difference between writing a new backend for something that is solid and in place and just throwing the whole product out the window and re-imagining it from the ground up, and I think the latter is the kind of rewrite that should be avoided and considered dangerous. When you could throw 4-5 guys on a real C# or C++ rewrite and tell them the final product has to behave identically to the PHP version, you have a much less volatile situation.

As for the PHP workflow, I agree it's nice not to have an intermediate step, but that intermediate step can usually be circumvented pretty rapidly by throwing a script or two (or just flipping a config option) into your development environment.

Re:A behind-the-scenes look at Facebook release engineering by nbm on Thursday April 05, 2012 @06:00PM (#3804862)
There is pretty much no way 4 to 5 guys could rewrite "www" in another language in parallel to continuing development from a hundred developers, no matter how long they had. However, 4 to 5 guys could write HipHop.

What real-world problems do you see staring Facebook in the face in its continued usage of PHP? I'm no PHP fan, but many of the common PHP problems are avoided or mitigated in the code base.

Re:A behind-the-scenes look at Facebook release engineering by ericd on Thursday April 05, 2012 @09:56PM (#3805611)
I think developing in PHP and compiling to C++/binary probably results in much higher developer productivity than developing in C++/C# directly. Developer salaries are undoubtedly their largest expense, by far, dwarfing those salaries of the people who make PHP performant and 1.5 gig binary updates sane.
Re:A behind-the-scenes look at Facebook release engineering by sciurus on Thursday April 05, 2012 @11:21PM (#3805839)
I expect that running their datacenters is a larger expense than developer salaries.

"In 2011, $606 million was allocated towards total capital investment in data center infrastructure by Facebook, which includes the cost of servers, networking equipment, construction, and storage." - http://www.colocationamerica.com/blog/facebook-data-center-i...

Re:A behind-the-scenes look at Facebook release engineering by evgen on Friday April 06, 2012 @12:13AM (#3805971)
The assumption that migrating the entire www stack to something like C++ would help with the datacenter costs is not supported by reality. Please remember that the bits that are in PHP are mostly front-end code. This handles the presentation of the data, but the actual heavy-lifting and data manipulation is done by the back-end infrastructure which is mostly C/C++ with some Java thrown in for the hadoop bits.
Re:A behind-the-scenes look at Facebook release engineering by nbm on Friday April 06, 2012 @01:18AM (#3806095)
I would disagree here - every percent CPU saved for the same workload is a 1% reduction in the number of machines needed. The number of web machines is sufficiently large that savings of even 1% are praiseworthy. Quite a bit of effort is expended to keep this going down and to the right (at least some of the time).
Re:A behind-the-scenes look at Facebook release engineering by ericd on Friday April 06, 2012 @03:55AM (#3806358)
Ah, good point, my estimate of their hardware spending wasn't that high. With 3000+ employees, depending on average total compensation, it might be close. That said, I would still guess that they'd choose greater developer productivity and agility over savings on server costs.

I wonder if there are any public benchmarks of compiled Hiphop vs. C++

Re:A behind-the-scenes look at Facebook release engineering by TeeWEE on Thursday April 05, 2012 @05:11PM (#3804652)
PHP is not such a bad language. Of course it has its quirks. However bad code is written by a bad developer, not by a bad language. You can write beautiful code in PHP too.

And the huge code base from Facebook is impossible to rewrite it in even a few years. Throwing away knowledge, tools, and tested code.

Re:A behind-the-scenes look at Facebook release engineering by mrich on Thursday April 05, 2012 @04:26PM (#3804452)
Thanks for your insights, but this makes me wonder: how much PHP code is there to make a rewrite unfeasible? At least the public part shouldn't be so big, are there huge administrative interfaces that somehow can't be separated?
Re:A behind-the-scenes look at Facebook release engineering by davidw on Friday April 06, 2012 @06:48AM (#3806638)
> Our search engine, newsfeed, and ad serving infrastructure, for instance, are in C++.

At one time the chat thing was supposedly done with Erlang - is that still true? Probably ejabberd hacked up, or something like that.

Re:A behind-the-scenes look at Facebook release engineering by underwater on Thursday April 05, 2012 @06:35PM (#3804995)
To add to what others have said most Facebook hires learn PHP during the boot camp process. The continued use of the PHP is definitely not due to lack of experience with other languages or some misplaced fondness for the language.

When you work on a codebase the size of Facebook's the core language becomes less important than the abstractions and framework that have been built around it. As well as having sane internal libraries Facebook have added extensions to the language like XHP and the yield keyword (http://www.serversidemagazine.com/news/10-questions-with-fac...) which make it much nicer to use.

Re:A behind-the-scenes look at Facebook release engineering by sciurus on Thursday April 05, 2012 @11:22PM (#3805841)
How large is the "www" codebase?
Re:A behind-the-scenes look at Facebook release engineering by underwater on Friday April 06, 2012 @01:25AM (#3806108)
To be honest I've never checked. Ola's answer here http://www.quora.com/How-many-lines-of-code-is-Facebook sounds about right (he seems to be talking about all code).

I should amend my previous comment though; most place I've worked at that are within a couple of orders of magnitude of Facebook's size have developed or adopted abstractions that constitute the majority of code engineers interact with.

Re:A behind-the-scenes look at Facebook release engineering by pbiggar on Friday April 06, 2012 @05:59AM (#3806558)
How good is the type inference? I did some research on PHP back in the day, and reckoned that a huge number of types (80%-90%) could be inferred - but I didn't run it on anything like Facebook's codebase.

Also, more info on the type inference please :) Context-sensitive? Do you model reference counts in your analysis? If so, do you get optimizations out of that?

Did the article really say a compile is 15 minutes? That's insane - how is it so fast? Does it limit the optimizations? You mustn't be able to do very deep analysis - or do you cache it somehow? What about FDO?

I've argued for years that the PHP interpreter's implementation leak into the language semantics, but you seem to have cast iron proof about the refcounts. Is it just destructors, or do you see errors due to copy-on-write semantics (like the weird array semantics when a reference is in a copy-on-writed array)?

(Sorry for all the questions, it's just very interesting)

Re:A behind-the-scenes look at Facebook release engineering by kmavm on Friday April 06, 2012 @12:43PM (#3807872)
I haven't done any work on the type inference stuff, so my understanding is second-hand. My peers who actually know what they're talking about are working on a more complete write-up, so stay tuned.

1. (Type inference.) The compiler's type inference is basically a first-order symbolic execution without inlining; we don't iterate to a fixed point or anything, and any union types at all cause us to give up and call it a variant. Many other PHP surprises mess up type inference; for example, function parameters by reference aren't marked in the caller, so if anywhere in the codebase there exists a unary function that takes its first parameter by reference, $f($a) will spoil our inference of $a: $f might mutate it.

Still, simple things work pretty well. One major area we do well on is inferring the return types of function calls. It's hard to say how much we're missing out by not doing more sophisticated type inference; while we can count the sites at compile time, this doesn't tell us which sites are dynamically important. Our anecdotal experience has been that type inference is one of the more powerful optimizations we can perform.

We don't model refcounts, and I'm certain there are opportunities there.

2. (Compile times.) 15 minutes sounds about right to me, and chuckr would certainly know better. Compiler speed itself is something we pay attention to, since it inhibits our ability to turn pushes around. The actual global AST analysis is multithreaded, so we keep the whole build machine busy. So far the trade-offs between optimizations and compile time have not been too dire; there haven't been things that would make the binary twice as fast if only we could compile twenty times as long, e.g.

3. (PHP implementation/semantics). Who've you been "arguing" against? :). It's a manifest fact that accidents of PHP's implementation have been sunk into the language. Destructors are one of the ways to witness refcounts, but there are others. var_dump() of arrays exposes the refcount of internal data; things whose refcount is >1 are displayed with a '&' preceding them, e.g.:

<? $a[0] = 1; var_dump($a); $data =& $a[0]; var_dump($a); unset($data); var_dump($a); ?>

produces

array(1) { [0]=> int(1) } array(1) { [0]=> &int(1) } array(1) { [0]=> int(1) }

Less trivially, it is hard to efficiently support the copy semantics for arrays without reference counting; other systems have overcome this, but it is less trivial than with refcounting.

Re:A behind-the-scenes look at Facebook release engineering by pbiggar on Friday April 06, 2012 @03:55PM (#3808633)
1) So what about the (I would think fairly common case) of loops where the variable is first initialized in the loop. On one path, it's null, on the other, it's a typed value. Can you optimize that?

2) Cool! phc went the route of really advanced, context sensitive analysis, and the result was massive memory use and huge compile times for even simple programs (if using optimization).

3) Have you read IBM's POPL 2010 paper on it? Interesting stuff, though maybe not actionable. They argue (there's that word again!) that PHP's copy-on-write is flawed for arrays containing references - the reference can lose it's reference-ness when the array gets altered and copied. They have an implementation which fixes this for a relatively small slowdown. Interesting paper as I recall.

FWIW, I think it's allowable to change the output of var_dump. Optimizing reference counts kinda requires it, and I know Hiphop isn't in the business of strict conformance to PHP semantics.

Re:A behind-the-scenes look at Facebook release engineering by kmavm on Monday April 09, 2012 @11:36PM (#3820547)
1) Great question! Yes, it is super-common. Most of our type inferences on local variables are actually of form "Null-or-X". So we can emit code that skeptically checks for Null, but then goes ahead and assumes X otherwise.

2) I'm not claiming we have all the answers here; but decent compile times has been a strong evolutionary pressure all along.

3) Yeah, we basically implement the "slightly relaxed" semantics described in that paper, and are addicted to the performance wins from doing so. WRT loosening semantics, though, in general you'd be surprised how close we come to quirk-for-quirk compatibility. The problem is that real PHP programs, including ours, end up depending, often unintentionally, on those quirks. I.e., nobody meant to rely on the order function params are evaluated in, but in practice we rely on it because param 0's evaluation has some side effect that param 1's evaluation needs to run correctly...

Re:A behind-the-scenes look at Facebook release engineering by dbarry on Thursday April 05, 2012 @02:38PM (#3803926)
I'd be interested in learning how the HipHop JIT is fitting into this picture, if you care to comment.
Re:A behind-the-scenes look at Facebook release engineering by kmavm on Thursday April 05, 2012 @02:50PM (#3803994)
The HHVM JIT isn't in (much of) production yet, because it isn't fast enough yet. Once we have high confidence it can provide some perf wins, we'll go ahead and move over to it. Even if it were perf neutral, there is some virtue to having developers use the same environment as production.
Re:A behind-the-scenes look at Facebook release engineering by jgrahamc on Thursday April 05, 2012 @01:23PM (#3803573)
I expect you end up with that when you decide that you never, ever want to have to resolve a problem with an executable and a dynamic library having incompatible versions.
Re:A behind-the-scenes look at Facebook release engineering by steadicat on Thursday April 05, 2012 @01:27PM (#3803590)
That binary includes the static assets. They're the origin for the CDN.
Re:A behind-the-scenes look at Facebook release engineering by YuriNiyazov on Thursday April 05, 2012 @01:42PM (#3803651)
The companies whose deployment processes I've seen did exactly that - after an update, a request to a CDN results in a fault which forces the CDN to query the original company server. In those cases, the static assets had to be distributed onto the servers.

I would imagine Facebook does the same, but the article pretty explicitly says that they don't do that (which is why I imagine you got downvoted - for the record, I think that was inappropriate), which raises the question of what exactly do they do?

Re:A behind-the-scenes look at Facebook release engineering by bonzoesc on Thursday April 05, 2012 @01:42PM (#3803652)
> The binary executable is just one part of the Facebook application stack, of course. Many external resources are referenced from Facebook pages, including JavaScript, CSS, and graphical assets. Those files are hosted on geographically distributed content delivery networks (CDNs).

It doesn't say whether or not these are part of the binary, but I'd suspect they aren't used as the CDN origin. You'd want these (randomly-but-uniquely named) resources to be pushed out to the CDN and warmed up before a deploy to avoid a thundering herd[1] problem from millions of users.

1: http://en.wikipedia.org/wiki/Thundering_herd_problem

Re:A behind-the-scenes look at Facebook release engineering by nbm on Thursday April 05, 2012 @02:00PM (#3803743)
Ignoring technical ways to work around the thundering herd problem, the slow rollout (employees first for several days, then a subset of servers, then a larger subset) also mitigates the problem.