Your linked article doesn't propose that the earning potential of college graduates isn't higher, it just states that people think the tuition price might not be worth it.

College educated adults absolutely have a substantially higher earning potential on average.