> the tests always pass
> it happens often that, even if the changes looks reasonable they are wrong
I’m having trouble reconciling these two statements.
When I review code, I’m rarely looking for bugs. Instead I’m looking for tests that would catch those bugs.
Do you have tests that verify that an abstraction hasn't sprung a leak?
Re:Unified versus Split Diff
by talent_deprived on Tuesday October 24, 2023 @01:42PM
(#38002559)
A somewhat minor nitpick, the word huge begins with a consonant sound, not a vowel sound. It would be correct to write "a huge issue" not "an huge issue".
Re:Unified versus Split Diff
by beaugunderson on Tuesday October 24, 2023 @03:36PM
(#38004241)
depends if you pronounce it 'uge or not ;P
(which is why you see some people write an history, because of the 'istory pronunciation)
Code review is hard because the diff always looks reasonable, the tests always pass and all the basic stuff are always checked.
However, it happens often that, even if the changes looks reasonable they are wrong.
The whole architecture may drift after one bad change that looks reasonable.
As always this is not strictly a problem with the tooling, but more of culture and knowledge sharing.
And we are not going to solve it with a better tool.