News for hackers. Stuff that matters.
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by thdc on Tuesday October 17, 2023 @11:05AM (#37916284)
Arguably it's less direct due to the superlatives and exclamations. For example:

> Christ. That's literally the remap_file_pages() system call definition. No way in hell does "ON_BEHALF_OF_KERNEL" make any sense in this context.

This could be

> That's the remap_file_pages() system call definition. "ON_BEHALF_OF_KERNEL" does not make any sense in this context.

If someone I didn't know or was unfamiliar with gave me a review like this I'd frown, but since Torvalds is known for this then I'd shrug it off probably. It's a good, thorough review though.

Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by withinboredom on Tuesday October 17, 2023 @11:16AM (#37916464)
The first is better, IMHO. No need to be so dry and boring in your second example. Also, in the first example, I know the reviewer is completely against my approach. I need some proper ammo to rebut with, or go back to the drawing board. In the second example, it could easily turn into a multi-day back-and-forth until one of us gives up.
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by endisneigh on Tuesday October 17, 2023 @11:34AM (#37916774)
I couldn’t disagree more. It’s simple a fact that the needless superlatives are verbose and distract from the point.
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by withinboredom on Tuesday October 17, 2023 @11:37AM (#37916810)
Congrats!? It’d be better if you could explain why… so there could be a discussion.
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by endisneigh on Tuesday October 17, 2023 @11:39AM (#37916851)
You’ve already made the point, otherwise you would’ve said:

“Jesus Christ, if you could just explain why then we could have a fucking discussion, yeah?”

Intuitively you already understand the point I am making :)

Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by withinboredom on Tuesday October 17, 2023 @11:47AM (#37916935)
I attack with laughter and sarcasm. Other people have different coping mechanisms. Mine just happens to be socially acceptable atm. It wasn’t always, such as in school where I was accused of not taking things seriously.
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by mcpackieh on Tuesday October 17, 2023 @03:05PM (#37920037)
His derisive "Congrats!?" would already be in violation of modern American corporate communication guidelines and policies. That sarcastic praise made me feel belittled. The exclamation mark made me feel threatened and unsafe. Failing to coddle me is aggression.
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by GrinningFool on Tuesday October 17, 2023 @04:26PM (#37921083)
I suggest: "I disagree. The needless superlatives distract from the point."

It conveys the same message without needless verbosity.

Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by endisneigh on Tuesday October 17, 2023 @06:20PM (#37922388)
True
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by pests on Tuesday October 17, 2023 @11:32AM (#37916733)
Ah yes, the best way to enforce technology decisions is by insults and hostility.
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by falcor84 on Tuesday October 17, 2023 @11:41AM (#37916870)
With Linux and git being probably the most widely adopted open source software projects ever, it would be a valid argument that Linus's approach is by historical proof "the best way".
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by endisneigh on Tuesday October 17, 2023 @11:45AM (#37916909)
This is a logical fallacy
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by falcor84 on Tuesday October 17, 2023 @03:04PM (#37920024)
Which fallacy?
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by endisneigh on Tuesday October 17, 2023 @05:50PM (#37922089)
Selection bias
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by withinboredom on Tuesday October 17, 2023 @06:34PM (#37922502)
I hate to be the bearer of bad news, but that isn't a logical fallacy. A logical fallacy is "A misconception resulting from flaw in reasoning, or a trick or illusion in thoughts that often succeeds in obfuscating facts/truth."[1] "Selection bias" isn't a recognized logical fallacy, in logical reasoning. "Selection bias" is a statistical bias in sampled data.

They put forth a premise, "With Linux and git being probably the most widely adopted open source software projects ever"

Then an inference, "Linus's approach is historical proof"

And a conclusion, "is the best way [to review code]".

Assuming we can accept the premise as true, you're left to attack the inference (whether or not Linus's approach is historical proof). You may disagree with the conclusion, but calling out a logical argument as a logical fallacy, and using that to dismiss the conclusion, is itself, a logical fallacy called a "fallacy fallacy"[2]

[1]: https://www.logicalfallacies.org/

[2]: https://www.logicalfallacies.org/fallacy-fallacy.html

Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by rjh29 on Wednesday October 18, 2023 @07:37PM (#37936264)
I understand why it could be selection bias. Let's say there are 100 open source projects with openly hostile communication. Only Linux succeeds. You can't point to Linux as proof that hostile communication results in success based on that 1/100 chance.

Similarly you can't just use a single anecdote to prove anything either.

I agree that the argument could be expressed better, but I personally understood the intention.

Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by withinboredom on Wednesday October 18, 2023 @07:54PM (#37936397)
Yes. They could have taken a moment to explain wtf they were talking about in both comments. It would have saved everyone a few moments of their day.

But sure. We can debate the premise.

If even only Linux and Git succeeded, out of hundreds of projects managed with hostility, that’s two projects; one guy. fWIW, out of hundreds of every other projects NOT managed with hostility (and similarly running on as many computers), most of those, that I’m aware of, aren’t flourishing like Linux is. Usually they suffer from attracting talent and people. Perhaps the hostility of Linus makes the projects more visible (bad news is good news in the PR world), and some people take it as a challenge to succeed there. Thus the project flourishes, vs. fail from lack of talent.

I’d also argue that I’ve (personally) let some truly shitty code into code bases at $dayjob over the years because there was simply no “nice way” to say it was so terrible. Trying to argue on technical merits would just go round-and-round until I gave up. I’m pretty sure I’ve used the same tactics a couple of times to merge some shitty code I don’t care about and actually want someone to rewrite if they ever need to change it.

The point is, had we have been hostile (and managed to not get fired), the code could be hundreds of times better. So, I’d be willing to bet, there isn’t a selection bias here and hostile behavior attracts talent (due to being highly visible; popcorn factor), forcing people to actually rethink really shitty code, and letting people be more candid about how they really feel.

Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by withinboredom on Tuesday October 17, 2023 @11:36AM (#37916788)
I reread it and didn’t see a single personal insult. Can you point them out?
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by jjice on Tuesday October 17, 2023 @11:13AM (#37916424)
I agree with the final sentiment but I do think you gave a good example of a more direct response. That said, there's something charming about seeing Torvalds's attitude come out. People really care about Linux and it warms my heart to see some passion.
Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by penguin_booze on Tuesday October 17, 2023 @01:47PM (#37918775)
Admittedly, the first is what runs in my head if I were reviewing a patch that touches something with which I'm intimately familiar.

The second is how I'd consciously phrase it, because I myself prefer someone not tell me the first one.

Maybe Linus doesn't do second takes (and that's not a secret).

Re:Google Proposes New Mseal() Memory Sealing Syscall for Linux by jonathanyc on Monday October 23, 2023 @03:35PM (#37990477)
And in spite of the superlatives and exclamations, the author still didn't seem to get the hint that they should maybe go back to the drawing board. See their post which Matt Wilcox is replying to.

I've worked in environments where it was considered a little mean even to use the "request changes" button in GitHub, but it worked because people (1) got the hint when you left comments suggesting changes and (2) would be careful to address all of your suggestions before requesting review again. But I've also worked in an environment where people would try to sneak changes past you and then argue with you when they were caught. I don't think I've ever sworn in a code review comment but these days I can understand where Linus Torvalds is coming from. Things would be much nicer if people got hints and were careful, but we don't live in that world.

My friend tried to use a credit card in Japan, and instead of saying "no" the shopkeeper just bowed and said "excuse me." Meanwhile yesterday in San Francisco I saw a customer arguing with the cashier for five minutes at McDonalds about whether or not they could use a coupon twice.