Re:Lessons from Bootstrapped Companies Founded by Software E...
by wizofaus on Sunday October 08, 2023 @06:59PM
(#37815187)
"You revert that commit, then. It's broken."
Personally I don't see why it's likely to cause major issues to allow people to merge PRs outside of business hours either, but depending on your team workflow and build pipeline (which may not be fully automated for any number of reason) it's not that hard to imagine cases where it's preferable to ensure all pushes to trunk occur during business hours (e.g. for cost saving reasons maybe you don't keep particular services running 24x7 that are needed to allow your integration test suite to run fully).
Re:Lessons from Bootstrapped Companies Founded by Software E...
by deathanatos on Monday October 09, 2023 @10:18PM
(#37827869)
> e.g. for cost saving reasons maybe you don't keep particular services running 24x7 that are needed to allow your integration test suite to run fully
We did this at an employ of mine. They were on-demand, and spun up when you committed.
I was mostly responding to what appeared to be the fear of "but what if someone broke main off hours!"
You revert that commit, then. It's broken. A revert shouldn't be take as some mark of failure or personal offense, it's just that your commit breaks the build, so it's getting removed from `main` until such a time as it doesn't do that. It happens to us all, from time to time. Those reverts almost always carry what at any profession organization should be an implied "feel free to bring this in a PR again, with fixes".
(And ideally, a bit of introspection as to "why didn't CI catch the failure when it was still on a branch?")