Reorient GitHub Pull Requests Around Changesets

Re:Reorient GitHub Pull Requests Around Changesets by setheron on Saturday September 30, 2023 @05:24PM (#37719979)

Surprised he didn't refer to stack PR based systems like Gerrit for reference.

I have never tried those apps that build a top GitHub. I remember Facebook's sapling has a web client as well that does stack reviews.

[ Parent | on HN ]

Re:Reorient GitHub Pull Requests Around Changesets by eyelidlessness on Saturday September 30, 2023 @05:27PM (#37720004)

There are two mentions of Gerrit in the article. Granted neither goes into detail, but both reference it as prior art on the topic.

[ Parent | on HN ]

Re:Reorient GitHub Pull Requests Around Changesets by setheron on Sunday October 01, 2023 @09:57AM (#37725996)

Oops. I must have missed the mentions.

[ Parent | on HN ]

Re:Reorient GitHub Pull Requests Around Changesets by adm_ on Saturday September 30, 2023 @05:42PM (#37720154)

I believe sapling uses https://github.com/ezyang/ghstack under the hood for stacked PR.

[ Parent | on HN ]

Re:Reorient GitHub Pull Requests Around Changesets by bittermandel on Saturday September 30, 2023 @06:31PM (#37720554)

Doesn't he do just that?

> They're already a well-explored user experience problem in existing products like Gerrit and Phabricator.

[ Parent | on HN ]

Re:Reorient GitHub Pull Requests Around Changesets by jacobegold on Saturday September 30, 2023 @09:12PM (#37721578)

I used to work at FB, and unfortunately the Sapling review client that shows GH PRs has nothing on the the actual internal code review tooling at Facebook (now called Diffs, formerly Phabricator). I miss that tool so much

[ Parent | on HN ]