Re:Linear code is more readable
by MathMonkeyMan on Thursday September 14, 2023 @11:22PM
(#37517922)
Each PR has 20 lines, and there are 30 such PRs over six months.
Re:Linear code is more readable
by Supermancho on Thursday September 14, 2023 @11:24PM
(#37517933)
Apologies. I wasn't clear. I meant it's a stretch to approve a function that's 600 lines. It would be very hard to reason about. I have clarified in my original post. Thank you for the feedback +1 to you.
Re:Linear code is more readable
by readthenotes1 on Friday September 15, 2023 @03:10AM
(#37519578)
600 lines is relatively short for some of the bad code that I have seen...
My code revivew tool shows me 3 lines of context around changes, which means the untouched comment won't even be seen unless i think to look for context. The tool also makes it hard to comment on those lines that were not touched but should have been.
I've used many code review tools, all suffered from that.
Yes, maybe it's the wrong abstraction or it won't match in 6 months because people will start calling Hats Pizzas and the logic will be different. Maybe I'll be dead tomorrow. I don't concern myself with what-ifs over unknowns.
I want correctness and some assurance of it. I don't think writing 50? tests to cover this thing is a good way to spend my time (or someone else's). I'll write the left hand side first. When I'm looking at writing tests, it will become something like the right hand side.
Yes linear code is more readable. That's something to consider, but it's not my primary consideration.