There isn't really any societal upside with smoking. It's a real net negative for the vast majority of users, financially and healthwise. Maybe smokers should switch to coffee for their high, a drug with no major downsides for most people.