Re:I don’t buy “duplication is cheaper than the wrong abstra...
by newaccount74 on Wednesday August 30, 2023 @03:03PM
(#37327259)
When I'm looking at a hex dump, FILE_HEADER_OFFSET doesn't tell me where to start looking for the header. So I need to open a new tab in my source code editor, find the header file where FILE_HEADER_OFFSET was defined, only to figure out that it is defined as FILE_MAGIC_LENGTH + RESERVED_FLAG_LENGTH, and FILE_MAGIC_LENGTH is defined as LENGTH(FILE_MAGIC_LITERAL), and FILE_MAGIC_LITERAL is not defined in the source code, because it is provided as a compiler flag that is generated by the Configure script, and there are three conflicting definitions of RESERVED_FLAG_LENGTH, and you are not sure which one is the correct one.
[ Parent
| on HN ]
Re:I don’t buy “duplication is cheaper than the wrong abstra...
by wvenable on Wednesday August 30, 2023 @04:39PM
(#37328738)
Get a better editor. I can mouse of FILE_HEADER_OFFSET anywhere it's used and get the value.
But still your describing a bit of a wild setup. If the value of FILE_HEADER_OFFSET is 42, how did you come to calculating the value? What if MEMORY_BLOB_OFFSET is also coincidentally 42? If you have dozens of source files filled with literal magic values that's completely unmaintainable and inscrutable.