News for hackers. Stuff that matters.
Re:Kernighan and Pike were right: Do one thing, and do it well by ahtihn on Saturday August 19, 2023 @07:11AM (#37187577)
You let interns push to production without code review?
Re:Kernighan and Pike were right: Do one thing, and do it well by prakhar897 on Saturday August 19, 2023 @07:26AM (#37187659)
Totally missed the point. Even with Code reviews, Unit/Integration Testing, Automated CI/CD and more can a person broke the prod.

One intern was told to deploy the app and I guess he made a mistake and updated k8 configs which deleted all the pods. Tell me how code reviews are supposed to catch it.

If you think "why not restrict config actions" etc, it's because the dev can go there and tweak those actions too. And each step added means less velocity of development. It's a game of cat and mouse. With isolation, you can limit the blast radius and loss of revenue.

Re:Kernighan and Pike were right: Do one thing, and do it well by sapiogram on Saturday August 19, 2023 @08:51AM (#37188261)
> Automated CI/CD

[...]

> One intern was told to deploy the app and I guess he made a mistake and updated k8 configs which deleted all the pods. Tell me how code reviews are supposed to catch it.

These sound contradictory to me. Part of having automated CI/CD, is not having to manually deal with k8s to do a regular deploy.

Re:Kernighan and Pike were right: Do one thing, and do it well by ahtihn on Saturday August 19, 2023 @10:22AM (#37189079)
> One intern was told to deploy the app and I guess he made a mistake and updated k8 configs which deleted all the pods. Tell me how code reviews are supposed to catch it.

So you don’t have a staging environment to check config changes before deploying to prod? Or you don't put k8s manifests (or helm charts or whatever)in source control and just update prod through CLI? And you let interns do it alone?

Your problem isn't interns, it's a terrible deployment processs with weak controls. Even senior engineers are going to break prod regularly in conditions like that.