News for hackers. Stuff that matters.
Re:GitHub will disable non-2FA accounts? by stephenr on Tuesday August 15, 2023 @07:59AM (#37132851)
So enable 2fa. What's the problem here?
Re:GitHub will disable non-2FA accounts? by countWSS on Tuesday August 15, 2023 @08:40AM (#37133244)
Its a huge change and increased burden to ordinary users and "ordering users to use 2FA or else" is not the tone i'd expect from website that thrive on voluntary participation, suddenly dictating that i could only login with specific setup from specific devices.
Re:GitHub will disable non-2FA accounts? by stephenr on Tuesday August 15, 2023 @09:05AM (#37133488)
By that logic, they should remove passwords too and just work on the honour system.

Seriously though, if using a TOTP generator or physical security key is a "burden" for someone, I really doubt they're the target audience for GitHub.

The benefits of 2FA are well known, and even if you have to enter the code manually (ie no browser integration) it's still arguably several orders of magnitude simpler in concept than most git operations.

Re:GitHub will disable non-2FA accounts? by lesserknowndan on Tuesday August 15, 2023 @10:02AM (#37134127)
Everything is fine until you realise the person that had 2FA for your organisation’s github admin account left the company six months ago and has deleted their 2FA key.

Also phones don’t seem to think it’s important to backup 2FA secrets so when you move devices you’re out of luck.

Re:GitHub will disable non-2FA accounts? by stephenr on Tuesday August 15, 2023 @10:15AM (#37134290)
> the person that had 2FA for your organisation’s github admin account

Why doesn't your organisation have at least two people with the Owner role?

> Also phones don’t seem to think it’s important to backup 2FA secrets

I've been using a TOTP app with backup functionality since at least 2014, so its not exactly a new concept. If you choose not to avail yourself of one, that's on you.

Re:GitHub will disable non-2FA accounts? by grayhatter on Tuesday August 15, 2023 @10:25AM (#37134394)
>Why doesn't your organisation have at least two people with the Owner role?

It's simple, just never make any mistakes.

> I've been using a TOTP app with backup functionality since at least 2014, so its not exactly a new concept. If you choose not to avail yourself of one, that's on you.

You're right! how dare they not know everything that you know.... it's insane that someone might not do everything exactly the way you think it should be done!

I get that's not what you're trying to say, but all you're doing is blaming humans for ignorance, or making mistakes. I'd assert, that given you clearly understand both security, and best practices, you'd be better equipped to help offer solutions instead of accusations, or blame.

Re:GitHub will disable non-2FA accounts? by stephenr on Tuesday August 15, 2023 @11:09AM (#37134917)
No, I'm blaming humans for wilful ignorance and insisting that there is no solution to problems they haven't tried to solve.
Re:GitHub will disable non-2FA accounts? by russelg on Wednesday August 16, 2023 @12:04PM (#37149167)
Most people don't recognise the importance of backups until they need said backups.
Re:GitHub will disable non-2FA accounts? by stephenr on Wednesday August 16, 2023 @12:23PM (#37149435)
Most people don't deny the existence of backup software once they realise they need it.
Re:GitHub will disable non-2FA accounts? by mattl on Tuesday August 15, 2023 @10:51AM (#37134700)
Google Authenticator didn't support backups until very recently which was surprising and caused some problems for friends of mine.
Re:GitHub will disable non-2FA accounts? by stephenr on Tuesday August 15, 2023 @11:12AM (#37134961)
So? It's not like Google authenticator is the only TOTP client available.

I really do have to wonder about the people who realised it's a problem to have no easy to use backup, but then apparently spent exactly zero minutes to try and find a solution.

Re:GitHub will disable non-2FA accounts? by mattl on Tuesday August 15, 2023 @11:18AM (#37135040)
A lot of things suggested Google Authenticator, so a lot of people installed it and used it, which sucks because no backups, so a lot of people had problems.
Re:GitHub will disable non-2FA accounts? by oskarw85 on Tuesday August 15, 2023 @01:18PM (#37136625)
Hey Mr. Know-it-all There WILL be a situation where you know nothing. Maybe your refrigerator would die and the technician would be scheduled two weeks from now. You would write about it on HN and some asshole would write:

So? It's not like shitty Samsung refrigerators is the only one model available.

I really do have to wonder about people who choose refrigerators using R407c refrigerant where temperature glide causes compressor valves to wear out prematurely. People apparently spent exactly zero minutes to try and find a solution.

Re:GitHub will disable non-2FA accounts? by stephenr on Tuesday August 15, 2023 @11:34PM (#37142577)
I mean this is just a terrible analogy to start with. I guarantee you it's a lot quicker, easier and cheaper to change your TOTP authenticator than it is to change a fucking fridge.

You clearly didn't understand the point I'm making so let me be more explicit: I don't expect people to know everything. As you allude to, it's impossible to know everything.

What I do expect, is for people to learn and try to resolve problems they face, rather than just sticking their head in the sand and pretending there's nothing they can do.

A more accurate analogy using your fridge example would be:

Johnny buys a POS Samsung fridge.

Unknown to Johnny, Samsung fridges use R407c refrigerant which causes the compressor valves to wear out prematurely. The compressor on his fridge needs to be replaced after just 3 years of use.

Rather than asking others for advice on the issue, Johnny now tells anyone that will listen, that all fridges will all need their compressor replaced after 3 years.

That's what's happening in this thread: zero requests for information or help about the issue; multiple posts claiming things that are factually incorrect, with absolute confidence.

Re:GitHub will disable non-2FA accounts? by warrenm on Thursday August 17, 2023 @07:56AM (#37160258)
> Everything is fine until you realise the person that had 2FA for your organisation’s github admin account left the company six months ago and has deleted their 2FA key.

What "organization" only has one person with access to the repositories?

These hypotheticals become goofier with each iteration

Re:GitHub will disable non-2FA accounts? by lesserknowndan on Thursday August 17, 2023 @08:44AM (#37160710)
Access to the Owner privilege is very different to having access to repositories.

Many small organisations may only have one person with an Owner account for the very reason that they don’t _need_ to have multiple people with access to that account as you share out access to repositories to team members that have less privileged accounts.

It is much “goofier” to assume that every organisation using Github has two people that have been granted an “Owner” level account.

Re:GitHub will disable non-2FA accounts? by warrenm on Thursday August 17, 2023 @01:05PM (#37164833)
I've yet to meet any organization that doesn't have at least 2 "owners" of a repo (that's in prod)

Once you pass from single user to "organization", multiple "ownership" is du jour

Maybe there are some out there - but they're stupid, if they are

Re:GitHub will disable non-2FA accounts? by grayhatter on Tuesday August 15, 2023 @10:21AM (#37134351)
As a security geek, and someone who's written on how passwords should be considered harmful. Github is wrong here. If I'm not willing to participate in this security "upgrade", it will not meaningful increase my security. In fact there's plenty of contrived scenarios in where this will decrease security.

Say I run a FOSS project and leave my 2fa at home when I leave for some vacation? And in that same time I get a report about a security bug. If I cant login to fix or even remove a binary. My users will be at risk! you'd better hope it's a short vacation.

Also, as an existing user of 2fa on GH, GH's implemention can get fucked! It auto submits 2fa otps for you. I've been locked out of my account for HOURS, multiple times because I'll one extra key without realizing it, only to have GH "helpfully" submit the wrong number, i wouldn't have, as the last chance before a lockout timer.

> what's the problem here

It's not anyone else responsibility to make security decisions for me. And if I wont play along with GH 2fa security rules, GH doesn't gain any security benefit themselves. Which means this new requirement can *only* make things worse. That's the problem. Also, I assume you didn't mean this comment to sound so dismissive, but that's definitely how it reads. Feels very much like your omitted preamble is "just do what GH tells you and don't complain".

Re:GitHub will disable non-2FA accounts? by stephenr on Tuesday August 15, 2023 @10:34AM (#37134499)
> there's plenty of contrived scenarios

Well at least you used the right word, even if you didn't intend that meaning.

If your OSS project has meaningful users, and a bus factor of one, it's already under those same risks every day you wake up, but it has the added risk of a malicious actor taking control of your account.

> I assume you didn't mean this comment to sound so dismissive, but that's definitely how it reads. Feels very much like your omitted preamble is "just do what GH tells you and don't complain".

I mean, I am pretty dismissive of anyone making such a fuss about 2FA. It's not hard to use, and the benefits far outweigh any slight inconvenience.

As I said previously, the target audience for GitHub needs to use Git on a regular basis, which is at least several orders of magnitude more complex than entering an OTP occasionally when you login via the web.

Re:GitHub will disable non-2FA accounts? by grayhatter on Tuesday August 15, 2023 @11:27AM (#37135158)
> Well at least you used the right word, even if you didn't intend that meaning.

I used contrived, because I meant contrived. They're invented.... until they happen.

While I'm pretty sure this will conflict with your world view. You don't understand the world in which I live better than me, and you don't understand my threat model better than I do. You'd convince a lot more people that you're right, if you even pretended like you believe that instead of acting like you're hot shit.

> If your OSS project has meaningful users, and a bus factor of one, it's already under those same risks every day you wake up, but it has the added risk of a malicious actor taking control of your account.

Passwords used correctly aren't less secure than passwords + 2fa. But they do increase the chance of lockout. And given human nature, if used incorrectly they might decrease it.

> I mean, I am pretty dismissive of anyone making such a fuss about 2FA. It's not hard to use, and the benefits far outweigh any slight inconvenience.

Well at least you're being honest about not caring about others. That's not nothing. But my advice to you, if you care about security, more than you care about being right, is to be less dismissive of people who think differently from you, maybe then you'll have a chance at convincing them of anything. Instead of what you're actually doing, which is trying to look cool on the Internet.

> and the benefits far outweigh any slight inconvenience ... the target audience for GitHub needs to use Git on a regular basis, which is at least several orders of magnitude more complex than entering an OTP occasionally when you login via the web.

to you... the benefit, inconvenient trade off is worth it to you... there are more scenarios than you can imagine. And I'd also argue you'd become better if you tried to fairly consider some of them, instead of being a douche. But you do make a point, it is more common that people who use gh more, are the most common users. It's not a good point, and it's what's known as a dick move, to everyone else that uses github slightly differently, but to hell with people different from you, right?

sigh

Re:GitHub will disable non-2FA accounts? by stephenr on Tuesday August 15, 2023 @11:21PM (#37142510)
> They're invented.... until they happen.

Well at least we're agreed your entire argument is based on made up theoretical scenarios, rather than the real world, where people's accounts are breached because of poor password security, literally on a daily basis.

> Passwords used correctly aren't less secure than passwords + 2fa.

What was that about acting like you're hot shit? There is essentially zero way for you to know that passwords are being "used correctly", because "used correctly" includes how they are stored and transmitted. You have no view into how the remote side stores or transmits passwords though. For all we know (yes this is a hyperbolic theoretical scenario), GitHub stores all passwords in plain text. Or md5'd, or some other equally laughable scenario. Or perhaps they log passwords during authentication. Or perhaps there's an unencrypted path between a load balancer and a backend application server, which is open to packet sniffing by peers in a datacenter, or any number of other issues that have shown to be real-world points of weakness to a password.

A big chunk of the benefit of TOTP based 2FA is that it greatly reduces the risk of replay style attacks. If you get the OTP I send (through logs or packet sniffing or whatever) it holds no long-term risk.

> Well at least you're being honest about not caring about others.

Straw man much? I didn't say I don't care about others. I'm very comfortable with the level of help/advice/expertise I offer to people who ask for it.

Nowhere in any comment I've seen on this post, has anyone asked for help or advice. A number of people have made ridiculously misleading, uninformed or just outright false statements, with absolute confidence. Hence why I said (in another comment, but still a reply to you):

> I'm blaming humans for wilful ignorance and insisting that there is no solution to problems they haven't tried to solve.

> there are more scenarios than you can imagine.

I'm sure there is probably some scenario where having 2FA enabled is a strictly worse scenario than password security alone.

But you'll want to have a pretty damn strong argument prepared, based on a real-world scenario before you should expect others to listen to what you have to say and take it seriously.

Right now you sound like a kid making up excuses about why they can't eat their vegetables.

Re:GitHub will disable non-2FA accounts? by nonameiguess on Tuesday August 15, 2023 @10:44AM (#37134609)
2FA is only required to login to the Github web app through your browser. You can perform API actions with a personal access token you can make as long-lived as you want, certainly long enough to last through a vacation.
Re:GitHub will disable non-2FA accounts? by grayhatter on Tuesday August 15, 2023 @11:34AM (#37135236)
I'm not foolish enough to bring any access control device through customs. That includes sessions keys. So either I bring everything, or nothing, and nothing is the safer security decision.
Re:GitHub will disable non-2FA accounts? by saltcured on Tuesday August 15, 2023 @12:43PM (#37136136)
After reading through several of your comment chains on this thread, I suspect something like a yubico security key with PIN protection enabled may be your least-bad option for travel with a second factor. The USB A ones are flat and thin and so easily carried whether in pockets, wallets, on a keychain, or even on a temporary necklace. The hardware is supposed to be somewhat resistant to key extraction, and the PIN means someone cannot instantly use it if taken from you.
Re:GitHub will disable non-2FA accounts? by grayhatter on Tuesday August 15, 2023 @01:09PM (#37136499)
I have no problem with 2fa. I have both available on my GH account. I think it's a bad decision, but I've been using 2fa on GH for over 10 years. I'm not arguing for myself, I'm arguing for others and for what's correct. In my case, i'm fortunate enough that when I need to go through customs, I have the luxury of being able to leave my 2fa at home :)
Re:GitHub will disable non-2FA accounts? by ecesena on Tuesday August 15, 2023 @11:10AM (#37134942)
You're restricted from some activities, not all. You already get asked for 2FA only for activities like changing team, adding ssh keys... not to commit. In your scenario, you'll just get these activities done after you're back.

(FWIW 2fa can be enabled on any phone now, both with totp and passkeys.)

Re:GitHub will disable non-2FA accounts? by mistrial9 on Tuesday August 15, 2023 @03:20PM (#37138136)
.. and your entire meatspace life records including payment information is linked to your phone?
Re:GitHub will disable non-2FA accounts? by warrenm on Thursday August 17, 2023 @07:54AM (#37160230)
>As a security geek, and someone who's written on how passwords should be considered harmful. Github is wrong here. If I'm not willing to participate in this security "upgrade", it will not meaningful increase my security.

You must neither be a "security geek" nor "someone who's written on how passwords should be considered harmful"

As an actual security geek, and one who has written on how to choose good passwords, I can assure you your worries are completely unfounded, and campaigning against 2fa is stupid at best

Re:GitHub will disable non-2FA accounts? by johngladtj on Tuesday August 15, 2023 @05:25PM (#37139467)
I don't like 2fa and don't want to use it.
Re:GitHub will disable non-2FA accounts? by warrenm on Thursday August 17, 2023 @07:58AM (#37160275)
Guess you're allowed to not like something

...but not wanting to use something that demonstrably makes you more secure (and is practically cost-free) does not make you look good

Re:GitHub will disable non-2FA accounts? by bsder on Tuesday August 15, 2023 @05:36PM (#37139576)
Because it's not about 2FA.

It will almost certainly be some shitty "We'll SMS your phone" thing in order to get your phone number.

And this will enable attacks from my phone that weren't there before.

Which actually makes me less secure.

Re:GitHub will disable non-2FA accounts? by jcotton42 on Tuesday August 15, 2023 @06:09PM (#37139921)
Not only does GitHub not require SMS for 2FA, they discourage it https://docs.github.com/en/authentication/securing-your-acco...
Re:GitHub will disable non-2FA accounts? by bsder on Wednesday August 16, 2023 @01:59AM (#37143353)
A TOTP phone app is the same problem as SMS--my phone is the authenticator.

It also provides a bunch of attack vectors like DDoSing my authenticator in order to get me to accidentally approve something.

And if my phone battery is dead, I can't log in.

And if my phone is stolen, I'm screwed.

None of these things improve MY security experience.

Re:GitHub will disable non-2FA accounts? by russelg on Wednesday August 16, 2023 @12:07PM (#37149221)
The main issue with SMS TOTP seems to be that phone numbers can be trivially stolen via social engineering, or less trivially via direct cell attacks. A TOTP app is effectively immune to both of these attacks. All your concerns are still quite valid however.