News for hackers. Stuff that matters.

A comment on git-appraise – Distributed Code Review for Git. Parent comment

Re:git-appraise – Distributed Code Review for Git by palata on Saturday August 12, 2023 @11:46AM (#37101353)
Sure, but what if your lead has a review list so big that they almost never get to empty it totally? I would consider that the time of such a lead is definitely more valuable than mine. Again, it's easy for me to accept that Linus Torvalds' time is more valuable than mine.

> If changing 3 lines is really an issue, then create a merge-tool for this workflow and add it to your git configuration file.

Or use the e-mail workflow, where the lead can just comment on the patch right away, without having to even pull the branch (and worse, push comment and potentially fix conflicts), right?

[ Parent | on HN ]
Re:git-appraise – Distributed Code Review for Git by withinboredom on Saturday August 12, 2023 @12:15PM (#37101674)
I understood that the presented workflow meant that it had already been reviewed, it just needed to be merged.

But on a team, I’d say there is no Most Valuable Player.

[ Parent | on HN ]