Re:Llama2.rs: One-file Rust implementation of Llama2
by cchance on Sunday August 06, 2023 @12:28AM
(#37018978)
is it just me or do others hate seeing structs with fields like x, xb, xb2, hb, hb2, q, k, v with comments to describe what they are drives me crazy...
why do some dev's insist on using short names in source code, it's going to get compiled away, just use descriptive names for variables it makes it so much easier to read, it seems to be something from c/c++, as I see it mostly in code from those, most rust code tends to have much more descriptive naming.
and then comments like this...
// token embedding table
token_embedding_table: [[fx; DIM]; VOCAB_SIZE], // (vocab_size, dim)
like commenting's an artform some times, but if your comments are literally just the exact same as the following/previous text, why are you commenting it :)
why do some dev's insist on using short names in source code, it's going to get compiled away, just use descriptive names for variables it makes it so much easier to read, it seems to be something from c/c++, as I see it mostly in code from those, most rust code tends to have much more descriptive naming.
and then comments like this... // token embedding table token_embedding_table: [[fx; DIM]; VOCAB_SIZE], // (vocab_size, dim)
like commenting's an artform some times, but if your comments are literally just the exact same as the following/previous text, why are you commenting it :)