It Takes 6 Days to Change 1 Line of Code

Re:It Takes 6 Days to Change 1 Line of Code by Macha on Sunday July 16, 2023 @12:32PM (#36748798)

> I also try to be clear when I don’t expect to do a second review if they make the minor changes, that the green check mark carries forward.

This is all well and good until your company brings in automation to enforce the setting that all changes dismiss reviews on all repositories.

Combine it with the requirement that all branches must be up to date with master before merging for the double whammy of rebase/review/repeat hell.

[ Parent | on HN ]

Re:It Takes 6 Days to Change 1 Line of Code by Tainnor on Sunday July 16, 2023 @01:18PM (#36749362)

Or instead imagine that you work in company where you actually can influence the settings of your repos so you can enable or disable these features whenever the team agrees on it. IMHO decisions like these should generally be up to the team, and I generally do turn off the "changes dismiss approval" setting because I trust my team mates not to abuse this.

[ Parent | on HN ]