It Takes 6 Days to Change 1 Line of Code

Re:It Takes 6 Days to Change 1 Line of Code by axpy on Sunday July 16, 2023 @11:58AM (#36748433)

Yes but it also did something that is potentially way more dangerous than the original ask. I would argue that pushing a parameter from a hard-coded value during an immediate outage or real production concern is stupid. There are way more potential pitfall there. IMO, This should have been handled with a:

OP: Please accept the 1 char PR, this is urgent. I just created a ticket to track the requested enhancements. Let's address production concern first then then I will get the rest after.

Reviewer: LGTM!

This is actually where seniority pays, if most of your engineering base can't navigate between rules and guidelines, the organization is crazy.

[ Parent | on HN ]

Re:It Takes 6 Days to Change 1 Line of Code by mesarvagya on Sunday July 16, 2023 @06:20PM (#36751997)

This. If it is a production issue that needs to be fixed, fix it fast with priority and create another ticket to take care of reviewers comments.

[ Parent | on HN ]