News for hackers. Stuff that matters.
Re:How Homakov hacked GitHub & the line of code that could h... by o1iver on Monday March 05, 2012 @11:00AM (#3666924)
"Homakov PUT an update to his own existing public key which included a new user_id. The user_id he used was that of a member of the Rails repository members."

But wouldn't that mean, that the commit would display the username of the user with the `user_id' that he used?

Re:How Homakov hacked GitHub & the line of code that could h... by gcampbell on Monday March 05, 2012 @11:19AM (#3667006)
Github displays the username/avatar for a commit based on that commit's Author field, not the user that pushed the changes to the repository.
Re:How Homakov hacked GitHub & the line of code that could h... by ajross on Monday March 05, 2012 @12:00PM (#3667185)
It's more that they display both. Unlike git core, github actually tracks "push" events to branches (git doesn't care, it only sees commits) as distinct from the commits they contain.

So presumably it would have shown the rails developer pushing a change authored by Homakov.

Re:How Homakov hacked GitHub & the line of code that could h... by technoweenie on Monday March 05, 2012 @01:00PM (#3667474)
Git has no real way to track that, only commits. We do track it internally, but AFAIK it's not exposed except through post-receive hooks.
Re:How Homakov hacked GitHub & the line of code that could h... by Tobu on Monday March 05, 2012 @06:21PM (#3668918)
ref changes are tracked in the reflog, but the "pusher" (as opposed to author and committer) isn't.
Re:How Homakov hacked GitHub & the line of code that could h... by o1iver on Monday March 05, 2012 @11:43AM (#3667107)
Ok, I see. Thanks!
Re:How Homakov hacked GitHub & the line of code that could h... by judofyr on Monday March 05, 2012 @11:21AM (#3667014)
GitHub uses the email-field in the commit to connect a user to a commit.