News for hackers. Stuff that matters.
Re:How Homakov hacked GitHub & the line of code that could h... by danso on Monday March 05, 2012 @10:45AM (#3666867)
I don't think this is the best way to describe this. It is not the "Rails Way" to NOT validate form input. The Github team used a method that allows quick and easy assignment of bulk values. This method is used often in non-public-facing tasks but when it is used in connection with a public facing POST request, then validation logic should be implemented.

It was not, in Github's case. It seems like a glaring error in retrospect but it's easy to see how this code (or the pattern) would move over from the private to public-facing interface and not trigger any errors or notice.

There are no comments on this comment yet.