News for hackers. Stuff that matters.
Re:GitHub and Rails: You have let us all down. by ericflo on Sunday March 04, 2012 @06:13PM (#3664515)
I fail to see what GitHub did wrong here. They were attacked, they suspended the account doing the hacking, and they fixed the problem. Then, they blogged about it, explaining in detail what happened. Apparently they weren't quite reverent enough for the person who wrote this article.
Re:GitHub and Rails: You have let us all down. by mquander on Sunday March 04, 2012 @06:49PM (#3664629)
Egor is a human whose motivations were totally obvious and whose actions were transparently harmless (and, in fact, net helpful.) The Github team are behaving foolishly if they can't or won't distinguish that from an "attack."

Organizations should be expected to make decisions using reasoning that amounts to more than word association, e.g. he "attacked" us, so we'll "suspend" him.

Re:GitHub and Rails: You have let us all down. by Fluxx on Sunday March 04, 2012 @07:05PM (#3664680)
I would disagree with this, quite a lot. He brought up an issue with the Rails team, they pointed him at the canonical, "here is where we talked about this before, sorry." Still not satisfied, he found the same exploit in Github to prove a point. Rather than do the sensible thing by creating a dummy account and contacting Github showing how he messed things up, he barged into the Rails organization and left a silly commit. Github is first and foremost a business organization where lots of companies pay them lots of money to "take this shit seriously" and protect their data, so they did the right thing by shutting him down.
Re:GitHub and Rails: You have let us all down. by mquander on Sunday March 04, 2012 @07:18PM (#3664709)
I honestly don't see the meaningful difference between contacting Github and leaving a silly commit, except that the former would probably get the bug fixed quietly; in contrast, now everybody is aware that the bug existed in Github and is aware of the potential for it to exist everywhere. He successfully proved his point, which apparently was a pretty good point. Isn't that a better outcome?

As for Github's responsibility: Github failed to protect people's data the minute the bug went live. That data was open to Egor since the moment he discovered the bug until the moment they fixed it. Making a silly commit did not make anyone's data more or less vulnerable, so I don't believe that "taking this shit seriously" implies flipping out over it.

Re:GitHub and Rails: You have let us all down. by Fluxx on Sunday March 04, 2012 @07:27PM (#3664738)
> I honestly don't see the meaningful difference between contacting Github and leaving a silly commit, except that the former would probably get the bug fixed quietly; in contrast, now everybody is aware that the bug existed in Github and is aware of the potential for it to exist everywhere. He successfully proved his point, which apparently was a pretty good point. Isn't that a better outcome?

I'm not denying that by doing what he did it certainly got the word out and made everyone understand how serious of a problem this is. It was a very good point and I think the outcome is the right one. I'm just saying that Github's actions - to suspend the user who somehow got SSH rights to the rails org - is the right thing to do. They want to minimize his damage that he will do, and until they can do a full audit and understand how his commit got there, it's the right thing o do.

> Making a silly commit did not make anyone's data more or less vulnerable, so I don't believe that "taking this shit seriously" implies flipping out over it.

I fail to see how suspending a user is "flipping out" over it? I don't think you can color unauthorized commits to github repos with different levels of responses from Github. That's a dangerous line to walk IMO.

Re:GitHub and Rails: You have let us all down. by Daniel_Newby on Sunday March 04, 2012 @08:01PM (#3664850)
> I honestly don't see the meaningful difference between contacting Github and leaving a silly commit, ...

The latter violates the Computer Fraud and Abuse Act, creating huge imprisonment and employability risks.

Re:GitHub and Rails: You have let us all down. by aroberge on Sunday March 04, 2012 @08:33PM (#3664964)
... if you want to take a US-centric view of things, then that last statement is correct I suppose... but not everyone is subject to US laws - including, unless I am grossly mistaken, the person you refer to.
Re:GitHub and Rails: You have let us all down. by Daniel_Newby on Sunday March 04, 2012 @10:00PM (#3665213)
GitHub's and its computers are governed by US laws, and many countries have extradition treaties. Many countries also have equivalent computer abuse laws.

My comment was to discourage such spectacular glory-seeking behavior by other people that claim to be trying to help. It's a serious crime, and the FBI does not care that your intentions were good.

Re:GitHub and Rails: You have let us all down. by mkramlich on Sunday March 04, 2012 @07:16PM (#3664707)
Perhaps these conditions are not mutually exclusive. It can be an attack, and, something done with good intentions to illustrate a point.
Re:GitHub and Rails: You have let us all down. by vidarh on Sunday March 04, 2012 @06:25PM (#3664561)
I lost a tremendous amount of respect for Github when I heard they'd suspended his account.

I have more of an issue with the Rails team for not accepting that this "feature" is a massive bug that they should've changed ages ago, though.

Re:GitHub and Rails: You have let us all down. by ericflo on Sunday March 04, 2012 @06:27PM (#3664564)
Why? I would expect any company to suspend the account of someone hacking them.
Re:GitHub and Rails: You have let us all down. by vidarh on Sunday March 04, 2012 @06:39PM (#3664599)
He did it under his own name, in a way dad not damage anything, using a problem that has been well known for ages, after attempting to draw attention to the issue several times and being ignored.

It is pretty obvious that he did not have any malicious intent, nor intended to do damage (if he wanted to, he could've done massive damage from an anonymous account in ways that wouldn't draw attention to it).

The only thing suspending his account accomplished is to punish someone who has helped draw attention to a very serious problem.

It just comes across as an incredibly childish and petty response given the circumstances.

Re:GitHub and Rails: You have let us all down. by elithrar on Sunday March 04, 2012 @07:05PM (#3664682)
> He did it under his own name, in a way dad not damage anything, using a problem that has been well known for ages, after attempting to draw attention to the issue several times and being ignored.

He was ignored by the Rails devs, not by GitHub. Yet GitHub became the target of his attack, because he was "bored" (his word, not mine).

At no stage, as far as we know, did he raise the issue directly with GitHub. As I've said in another thread, he could have done so and requested they disclose the fix publicly (say, within 24 hours) in an effort to force the Rails devs' hands. Instead, he's punished GitHub (who, mind you, probably should have audited for this vulnerability a long while ago) because he was shunned by the Rails devs.

Re:GitHub and Rails: You have let us all down. by hythloday on Sunday March 04, 2012 @07:23PM (#3664725)
If you read the Github advisory, he did indeed raise the issue with them "last Friday":

https://github.com/blog/1068-public-key-security-vulnerabili...

Re:GitHub and Rails: You have let us all down. by silentOpen on Sunday March 04, 2012 @06:39PM (#3664595)
When you've tried to inform the vendor and have been rebuffed, a demonstration of the vulnerability helps convey the gravity of the issue.
Re:GitHub and Rails: You have let us all down. by artursapek on Sunday March 04, 2012 @06:44PM (#3664613)
The point is he did them no harm when he could have done a lot of it.
Re:GitHub and Rails: You have let us all down. by dos1 on Sunday March 04, 2012 @06:43PM (#3664609)
Sure, that was my knee jerk reaction too. Of course they should suspend the account! But I think that was the wrong choice.

Shutting down the one account will do nothing. He can create a second account in a matter of seconds. They fixed the code that permitted the exploit, right? So the fix alone should be plenty to prevent any more malicious attacks.

And now, because of the suspension, they have a wave of bad PR (justified or not). This guy is clearly infatuated with Github. He got a tattoo of the Octocat for crying out loud. Why would you punish this guy for loving your service and caring enough about it to warn you of a security vulnerability?

Seems like there are only minuses to suspending the account, not a lot of pluses.

Re:GitHub and Rails: You have let us all down. by emc12 on Sunday March 04, 2012 @06:49PM (#3664628)
I would expect any company to do far more than suspend the account, especially knowing exactly who did it.

I would think having a suspended GitHub account would be the least of worries with a company who has presumably access to a good lawyer or two and boatloads of cash...

Re:GitHub and Rails: You have let us all down. by wycats on Sunday March 04, 2012 @06:37PM (#3664591)
All of my public comments on this topic agree that this is a problem that we should fix. Are you conflating me with other people? Am I not part of "the Rails team"?
Re:GitHub and Rails: You have let us all down. by vidarh on Sunday March 04, 2012 @06:41PM (#3664603)
The issue is that it needed to go this far before someone actually paid attention to it. It indicates a cultural problem that is not going to get addressed by fixing a single technical issue.