News for hackers. Stuff that matters.

A comment on Type-safe, K-sortable, globally unique identifier inspired by Stripe IDs. Parent comment

Re:Type-safe, K-sortable, globally unique identifier inspire... by dolmen on Thursday June 29, 2023 @04:55AM (#36518021)
There is no tests.

There is just a single test. Which only tests the decoding of a single known value. No encoding test.

Go has infrastructure for benchmarking and fuzzing. Use it!

Also, you took code from https://github.com/oklog/ulid/blob/main/ulid.go which has "Copyright 2016 The Oklog Authors" but this is not mentionned in your base32.go.

[ Parent | on HN ]
Re:Type-safe, K-sortable, globally unique identifier inspire... by dloreto on Thursday June 29, 2023 @04:00PM (#36525894)
We've now implemented pretty thorough testing: https://github.com/jetpack-io/typeid-go/blob/main/typeid_tes...

Thanks for the feedback!

[ Parent | on HN ]