Re:We started requiring code reviews for everything, and my ...
by sonnekki on Tuesday February 28, 2012 @02:56PM
(#3644678)
What about changes that are required during off-hours when there there is a problem: Wait until works hours to implement in production? Is this not a consideration given the context?
[ Parent
| on HN ]
Re:We started requiring code reviews for everything, and my ...
by kscaldef on Tuesday February 28, 2012 @03:21PM
(#3644799)
TFA says, "If you have a legitimate emergency, push it and get it reviewed later, ain’t no thang"
But, also, strive for a level of code quality that doesn't require that sort of thing.
Re:We started requiring code reviews for everything, and my ...
by jonstjohn on Tuesday February 28, 2012 @06:37PM
(#3645597)
We do code reviews for all committed code, but if there is an emergency in production, we deal with it the best way we can. If that means a quick fix put directly in production, we do it, but there is always a review the following day. Process is great until it isn't working - sometimes you have to side step it or even change it.