News for hackers. Stuff that matters.
Re:I gave commit rights to someone I didn't know by opportune on Tuesday May 30, 2023 @01:04PM (#36127395)
Almost every time I’ve reviewed a 1k+ LOC PR, even if it’s from a really experienced and good engineer, it has introduced a bug. Obviously I’m not gonna say it at work, but changes that big are too hard to properly review and consider all side effects and gotchas
Re:I gave commit rights to someone I didn't know by tstrimple on Tuesday May 30, 2023 @02:17PM (#36128416)
It's also more difficult to bisect to find the actual bug. Small commits have a lot of advantages.