if he was such a bad person, why is he doing so much good in the world?
1. How much actual knowledge people have of Elon. Speaking from personal experience there is very much a "familiarity breeds contempt" thing going on here, and I suspect the same is true more generally. People exposed only to his early (positive) press will likely like him. People exposed only to his later (negative) press will likely hate him.
2. What part of Elon's portfolio they care most about. No matter how a space nerd feels about Elon they are going to have some positive vibes about SpaceX. Even people at competitors felt their hearts flutter when they saw the first double F9 landing, or first saw Starlink high in the night sky. But people who love cars... not so much. Plenty of folks who would sooner key a Tesla than own one, and will tell you so to your face.
I also think that while lots of liberals are annoyed at Elon, the bulk of the hate comes from conservatives. Hard to erase a decade-long lead in pissing people off.
and for the cars, teslas are selling quite well, its the only profitable ev according to recent business report apparently.
If you mean "every time I am smoking a joint and talking about Elon" I guess I'm not surprised. If you mean "every time I go outside and talk to people about Elon" I definitely am. There are large parts of my (quite liberal) state where a Tesla gets a pretty negative reaction.