Re:Are pull requests bad because they originate from open-so...
by brazzy on Tuesday April 25, 2023 @11:24AM
(#35701766)
Sounds to me that the real takeaway is that the essentials you list don't, in fact, matter if you have incompetent developers.
[ Parent
| on HN ]
Re:Are pull requests bad because they originate from open-so...
by RugnirViking on Tuesday April 25, 2023 @11:36AM
(#35701955)
well certainly if you have incompetent developers in senior management, but is that a surprise to anyone? I don't think a good git workflow or whatever could ever fix something like that
Re:Are pull requests bad because they originate from open-so...
by gorjusborg on Tuesday April 25, 2023 @03:00PM
(#35705065)
To me, code review is a tool that can make incompetence a temporary condition.
People have to be open to constructive feedback and want to grow, however.
Re:Are pull requests bad because they originate from open-so...
by jiggawatts on Tuesday April 25, 2023 @04:10PM
(#35706037)
Having a code review policy is like having speed limit signs on the motorway.
Without enforcement, you can make the argument that speed limits don’t save lives because everyone drives as fast as they can anyway.
Same thing for code review. If it’s not policed by management, then it does nothing.
I saw one place that would send alert emails if a commit was approved too fast, assuming that someone must have had it insta-approved by a friend as a favour.