News for hackers. Stuff that matters.
Re:ZSTD 1.5.5 is released with a corruption fix found at Google by voltagex_ on Tuesday April 04, 2023 @07:25PM (#35447203)
What's stopping those 4 patches from being upstreamed?

What advantages or disadvantages am I getting from them?

Re:ZSTD 1.5.5 is released with a corruption fix found at Google by miffe on Tuesday April 04, 2023 @08:38PM (#35447739)
Looking at it it seems to require avx2. And use the "m" mode for fopen(), which I have no idea what it does, it's not in any documentation I can find.
Re:ZSTD 1.5.5 is released with a corruption fix found at Google by aslatter on Tuesday April 04, 2023 @09:13PM (#35447980)
From my fopen(2) docs:

m (since glibc 2.3)

Attempt to access the file using mmap(2), rather than I/O system calls (read(2), write(2)). Currently, use of mmap(2) is attempted only for a file opened for reading.

Re:ZSTD 1.5.5 is released with a corruption fix found at Google by eklitzke on Wednesday April 05, 2023 @12:36AM (#35449360)
I'm very skeptical that this actually makes things faster. For one, zstd is definitely going to be CPU bound rather than I/O bound. But even if it wasn't, there shouldn't be a performance benefit to reading a file sequentially using mmap compared to reading it sequentially using read, which you can easily verify yourself by writing a small program that just reads files both ways.
Re:ZSTD 1.5.5 is released with a corruption fix found at Google by dikei on Wednesday April 05, 2023 @02:06AM (#35449969)
I think for clear linux, it might be for memory saving in constraint devices rather than for speed optimization.
Re:ZSTD 1.5.5 is released with a corruption fix found at Google by dikei on Tuesday April 04, 2023 @09:47PM (#35448210)
When a distro maintains patches, it's mostly down to either:

* Change default value for some parameters, that can't be upstream due to compatibility reasons.

* Change build flag / macro for optimization and/or workaround compiler bugs.