Arguably there's a place for both an em-dash and a hyphen. (For your example, a hyphen would be pretty normal style anyway.) But in a world where double quotes is a massively overloaded punctuation mark we probably don't need an en-dash at least.