News for hackers. Stuff that matters.
Re:Show HN: Programming language for making NES games by eru on Tuesday March 07, 2023 @08:57PM (#35064208)
Why? Sticking your whitespace rules in the linter is a great way to keep them from taking up valuable time and attention in (human!) code review.
Re:Show HN: Programming language for making NES games by incrudible on Tuesday March 07, 2023 @09:39PM (#35064510)
You will pay for it in wasted time and nerves on fixing whitespace warnings just to make the linter shut up.
Re:Show HN: Programming language for making NES games by eru on Wednesday March 08, 2023 @04:35AM (#35066992)
Use an auto-formatter.
Re:Show HN: Programming language for making NES games by incrudible on Thursday March 09, 2023 @09:30AM (#35081518)
If you use an auto-formatter then just run that before you check in your code instead of setting up redundant linter rules that run every time you compile.
Re:Show HN: Programming language for making NES games by eru on Friday March 10, 2023 @09:48PM (#35104626)
You set up the linter to run as a check for pull-requests.

What people do locally to pre-emptively comply with the pull-requests rules is up to them, like running the auto-formatter before they commit their code, or running the test suite before making a pull-request.

Re:Show HN: Programming language for making NES games by incrudible on Saturday March 11, 2023 @02:05PM (#35111475)
Fair enough. The thing is, if you do not fuss about whitespace, none of that even comes up. Nobody needs to set this up, make the decisions, integrate it, deploy it, maintain it and then have everyone annoyed by it until they get used to it. The people who think we need such a system are the ones I do not want on the team, because odds are that they are nitpickers whose peculiarities permeate their entire work. Brilliant people perhaps, but they better work on their own.
Re:Show HN: Programming language for making NES games by eru on Saturday March 11, 2023 @10:53PM (#35116445)
To start: I agree that reasonable people can work together on a common code base without a strict common ruleset and only a loose shared understanding.

However: some reasonable people also like to use auto-formatters.

If you want to avoid a lot of noise when looking at diffs eg for your code review, you need to deal with those.

The most obvious problem is two people with differently set-up auto-formatters.

But you also get a problem when you mix people hand-formatting vs the auto-formatter. The first time the auto-formatting developer touches a file, you have a massive diff.

(With lots of discipline, they can stick the formatting into a separate commit or even PR, but people seldom do that.)

All that being said, I'm a very selective stickler for whitespace formatting. I like my source to be neat, and my diffs to be easy to review. I'd like people to avoid mixing tabs and spaces, avoid trailing spaces at the end of lines, and end their last line in a file with a newline.

> Brilliant people perhaps, but they better work on their own.

I have the opposite experience: people who don't cross their Ts nor dot their Is are also those who forget other niceties like freeing their malloced memory.

I approach coding from the point of view as trying to make the reviewer's life as easy as possible. So not just 'how do I get the computer to do X', but 'how do I make this so easy to understand that a reviewer has a chance of spotting any mistakes I make' (also so that reviewers and other readers of the code can take over, so I can take a vacation or move on to other things).

Re:Show HN: Programming language for making NES games by incrudible on Sunday March 12, 2023 @08:20PM (#35128741)
I have no problem with auto formatters, because I do not fuss about white space. I turn off whitespace changes when viewing diffs. The end.