Source: I cushion my robots this way, haven't gotten to the ebike yet.
On the whole it isn't perfect but good enough for many years, I've run this setup for a year now and have once (at 5K km) inspected the wiring and the battery welds and everything seems to be holding up quite well. Things to be careful with: overpressuring the tires would reduce the amount of shock absorbing capacity quite a bit (and is definitely not recommended with tires this wide anyway), the rolling resistance of these is fairly high but that is just how they are designed. Then, obviously there is bumping in to things and falling at speed, which fortunately hasn't happened. But if it did I would immediately consider the battery pack a write-off in spite of being super well protected. I've done about 10K on it now and when it hits 20 I'll take the whole thing apart to see if there is any wear that is hidden from view. I'm mostly concerned with the battery welds and the wiring, those are the weak points, even with all of the wiring contained within the enclosure, routed carefully to never cross over any other wires and with the welds checked using a FLIR during a pretty rapid discharge (twice as fast as the motor could ever do).
The OP has mounted the charge controller and the motor controller to a piece of wood (which will flex a bit but not much) which in turn appears to be protected in only one axis (side-to-side) and is either free to move or rigid in the other two. The wiring runs 'cold' without any kind of extra protection through the wood that it is mounted on. The frame is unsprung as far as I can tell, which especially for the front is not a luxury on a bike this heavy, which makes bike+battery the unsprung weight (I think I see a saddle pin with a rubber mount so there is some flex there). That battery box may have some foam in it or some other suspension for the battery which is good.
As long as he's on good asphalt this setup will work, but as soon as you go on less perfect roads I think that it will give trouble over time. DIY stuff like this looks great on the day you build it if you don't build it for abuse, but exposed wiring is dangerous and vibration as well as the weather are going to be rough on this. I'm curious what it will look like a year from now if used intensively, and also how the wire runs are on the other side of that board.
End result, everything is perfectly potted except the topside of an aluminium heatsink.
Also, the electronics are mounted out in the open and on top of a small bit of wood, that works well in the lab but if you're going to be biking and end up being rained on it may well cause issues, just using splash proof connectors isn't enough, you need to protect the electronics from the elements by eliminating direct contact with the elements. Much like in a car: all of the connectors under the hood are waterproof and they are under the hood, not out in the weather.
That said, it's a neat idea.