News for hackers. Stuff that matters.
Re:Don’t Teach During Code Reviews by Hermitian909 on Sunday February 05, 2023 @05:45PM (#34670552)
(I'm Not OP) - At the end of the day we're all trying to strike a balance between shipping fast and keeping technical debt down. Asking juniors to only ship code that's good as what a senior would write is very rarely the right balance point. Senior engineers must learn to understand when code is "good enough". If you're a senior and you haven't developed this skill you're bringing your team down.

Concretely, a heuristic I rely on is to understand whether the sub-par code being added "infects" the code base e.g. it changes an important interface, it adds a poorly designed interface other code will rely on etc. These are the places its important to put your foot down. Conversely, if the internals of a one-off function or class could be a little cleaner... eh, ship it.

Re:Don’t Teach During Code Reviews by 88913527 on Sunday February 05, 2023 @06:28PM (#34670986)
Being more forgiving on code quality can be balanced with more testing. I can't control how clean every abstraction will be, but we can at least have automated regression checks and ensure ongoing contributions don't break anything. The customers only see the end result of our work, they don't see the code.
Re:Don’t Teach During Code Reviews by Ensorceled on Sunday February 05, 2023 @06:05PM (#34670763)
> Senior engineers must learn to understand when code is "good enough". If you're a senior and you haven't developed this skill you're bringing your team down.

Holy shit. I should have just written this.