Re:Don’t Teach During Code Reviews
by doutunlined on Sunday February 05, 2023 @05:29PM
(#34670367)
Why would you rewrite them as loops?
[ Parent
| on HN ]
Re:Don’t Teach During Code Reviews
by Ensorceled on Sunday February 05, 2023 @05:33PM
(#34670422)
"It's much easier to read a loop than a list comprehension, please rewrite all the list comprehensions as loops."
I squashed that.
Re:Don’t Teach During Code Reviews
by schrodinger on Sunday February 05, 2023 @07:07PM
(#34671391)
Sounds awfully micromanagey, making the decision as someone with way less context than the senior engineer… unless you have OCD and non-pragmatic engineers upholding unreasonable expectations.
List comprehensions are advised against in Google’s official Python Style Guide and many similar guidelines for this exact reason. You sound like a micromanager who thinks he’s more technical than you actually are