Re:Serving Files in Python: How FastAPI Failed Us
by alsadi on Wednesday February 01, 2023 @11:16PM
(#34621989)
As I pointed out in my other comment, serving a static file should be a single call to a kernel routine called sendfile (sendfile in c or in python io.sendfile or loop.sendfile). No loop, no memory copy, no further context switch.
Again if you think I was not fair to fastapi, suggest a change to the fastapi part. Do not cripple the competing solution.
If you want believe the time is wasted by the introduction of uvicorn layer as opposed to pure python implementation, I can run the fastapi in pure python ASGI without that layer, it would be worse. Because you uvicorn is one of the best implements.
Re:Serving Files in Python: How FastAPI Failed Us
by alsadi on Thursday February 02, 2023 @02:23AM
(#34623305)
here I've eliminated uvicorn, nothing changed
https://gist.github.com/muayyad-alsadi/3a1e1cdbafca34df8b178...
And no, I’m not going to fix your benchmarks for you. This does not provide any value to me but does come at a time cost.
I appreciate you raising the issue and performing research on it, that’s valuable and I applaud you for that. I simply don’t believe that this is a valid benchmark from a technical soundness perspective.