Re:Upgrading Airbnb from Rails 2.3 to Rails 3.0
by ssorallen on Wednesday January 04, 2012 @05:11PM
(#3426152)
> Why are you blogging about upgrading to Rails 3.0.x when the current stable Rails has been 3.1.x for over 4 months?
Like mentioned in another comment, upgrading from 2.3.x to 3.0.x is a feat in itself. Upgrading from 2.3 to 3.1 might be doable on a smaller project, but with code written in several versions of Rails we decided to go 2.3 > 3.0 > 3.1.
> Also, shouldn't these simple bugs be quickly and fully discovered by automated tests?
There was plenty of HTML inside Ruby statements in our templates that started being escaped. Something like:
while ugly was not wrong. This is a very simple version of some of the problems we saw, and there were typically several per template. Writing tests that check the HTML output of template files would be unmaintainable.
> If the upgrade is done on a branch, why must the work be completed during the weekend?
To avoid a big merge. We changed a lot of files and didn't want to have to re-check our work after letting Git auto-merge our changes.
Like mentioned in another comment, upgrading from 2.3.x to 3.0.x is a feat in itself. Upgrading from 2.3 to 3.1 might be doable on a smaller project, but with code written in several versions of Rails we decided to go 2.3 > 3.0 > 3.1.
> Also, shouldn't these simple bugs be quickly and fully discovered by automated tests?
There was plenty of HTML inside Ruby statements in our templates that started being escaped. Something like:
<p><% (price > 10) ? '<strong>Expensive!</strong>' : 'Cheap' %></p>
while ugly was not wrong. This is a very simple version of some of the problems we saw, and there were typically several per template. Writing tests that check the HTML output of template files would be unmaintainable.
> If the upgrade is done on a branch, why must the work be completed during the weekend?
To avoid a big merge. We changed a lot of files and didn't want to have to re-check our work after letting Git auto-merge our changes.