Re:Why SQLite succeeded as a database (2016)
by docandrew on Thursday January 05, 2023 @10:54AM
(#34261517)
For smaller projects that don’t obviously have a lot of contributors, I think it is good etiquette to ask the maintainers ahead of time if they’re open to PR’s before submitting one, because like you said, it takes effort to accept patches.
Re:Why SQLite succeeded as a database (2016)
by jraph on Thursday January 05, 2023 @11:02AM
(#34261689)
Well, contributors should check if there are stated policies, but I think it's the author's duty to document that they don't take contributions and to disable the relevant features in the tools they use.
A contribution is a nice thing from the contributor.
As a contributor, I won't ask and then open a MR for a trivial contribution. It's too much trouble. I will ask for a bigger contribution to know if the author had related plans or their ways though.
As an author, I do state that I'd rather not have medium/big contributions before we discussed about it in the project's CONTRIBUTING file.
Re:Why SQLite succeeded as a database (2016)
by dspillett on Thursday January 05, 2023 @11:57AM
(#34262763)
> but I think it's the author's duty to document that they don't take contributions
It is polite to do so, and I'd make the effort, but I certainly wouldn't call it a duty at all.
> and to disable the relevant features in the tools they use.
That isn't always possible, and even when it is this does not stop contributions perhaps coming in by other means (email if you have an address publicly known, issue reports, …).
Taking contributions requires effort on the part of the maintainer and I think it’s completely fair to want to open the code but not deal with that aspect of open source.