News for hackers. Stuff that matters.
Re:Boring Python: Code Quality by Smotko on Tuesday December 20, 2022 @07:09AM (#34064795)
I don't understand why people are against this so much. Black does a sanity check and compares the AST before and after to make sure there aren't any meaningful changes (unless you are running it with --fast). So there is almost no risk that it will break your code.

There is nothing more frustrating than coming back from a coffee break only to find out that you have to rerun your CI check because of a trivial formatting issue.

Re:Boring Python: Code Quality by hbrn on Tuesday December 20, 2022 @12:13PM (#34068866)
If you use feature branches, it is quite annoying that can't push two consecutive commits because CI changed something in your branch and now you have to resolve conflicts.
Re:Boring Python: Code Quality by craftkiller on Tuesday December 20, 2022 @01:04PM (#34069685)
We have it set up to only run after you've opened a PR. You shouldn't run into the issue often that way because if you're opening a PR then all your big immediate changes are already committed so you won't be pushing another commit until someone reviews which will be after black has already finished.
Re:Boring Python: Code Quality by hbrn on Tuesday December 20, 2022 @01:14PM (#34069840)
This really depends on the workflow.

Sometimes I still sneak in minor changes after I opened a PR. Sometimes I open PR early because CI has integration/e2e tests that are hard to run locally. Sometimes I want feedback on certain parts early on and PR is the easiest way to show something.

There can be workflows in which pushing through CI works fine, but as a general advice it's not great.