If you want to handle `$EDITOR` not being set, at least in bash, you can use one of it's parameter expansion features:

    ${EDITOR:-vim}

Will use vim if `$EDITOR` is unset.