Re:Substack is (not) now powered by Ghost
by bambax on Monday December 12, 2022 @12:41PM
(#33957611)
Minified versions of most JS libraries include a copyright notice as a top or bottom comment. How hard is it to respect this basic requirement?
[ Parent
| on HN ]
Re:Substack is (not) now powered by Ghost
by jairajs89 on Monday December 12, 2022 @01:46PM
(#33958495)
Hey, Substack CTO here. We actually link directly to the jsdeliver CDN to use the files that get built for distribution in the sodo-search npm library. We make no modifications to the files (including not minifying them anymore than they are). The files actually do have a link at the top to the license file, which is hosted in the same directory on jsdeliver.
Re:Substack is (not) now powered by Ghost
by bakkoting on Monday December 12, 2022 @03:19PM
(#33959676)
> The files actually do have a link at the top to the license file
That's not actually the license for the file; it's the license for the resources it includes. The license for the file is available elsewhere but is not directly linked. See my comment at https://news.ycombinator.com/item?id=33959622
Re:Substack is (not) now powered by Ghost
by srt72910 on Monday December 12, 2022 @01:48PM
(#33958508)
understood
Re:Substack is (not) now powered by Ghost
by coldtea on Monday December 12, 2022 @01:23PM
(#33958167)
Quite hard. Isn't the whole point of the minification to remove non functional parts to make the size smaller?
Re:Substack is (not) now powered by Ghost
by zerocrates on Monday December 12, 2022 @01:28PM
(#33958235)
Not really hard... for one there's a convention of putting an exclamation point at the start of comments that should survive the minification/compilation process, for this very purpose.
Re:Substack is (not) now powered by Ghost
by bambax on Monday December 12, 2022 @01:43PM
(#33958457)
Not hard at all. A couple of comments won't make any difference. Here's the minified version of one of react components for example:
https://unpkg.com/[email protected]/umd/react.production.min.js