News for hackers. Stuff that matters.

A comment on Improving code review time at Meta. Parent comment

Re:Improving code review time at Meta by H8crilA on Thursday November 17, 2022 @07:42PM (#33648206)
If you're working 8 hours and do at least 4 breaks per day - that's a break every 2 hours. If you do a break you might as well skim through emails and do some reviews. And remember that everything* is Pareto distributed, the review request sizes too. It's really not hard at all.

[*] it's an exaggeration, but close to reality.

[ Parent | on HN ]
Re:Improving code review time at Meta by screamingninja on Thursday November 17, 2022 @08:02PM (#33648386)
> If you do a break you might as well skim through emails and do some reviews.

That's not exactly a break...

[ Parent | on HN ]
Re:Improving code review time at Meta by H8crilA on Thursday November 17, 2022 @09:03PM (#33648878)
Well, after or before the break. The point is you're going to lose context completely anyhow.

And I'd like to stress the distribution of the "complexity of a review", which you can crudely approximate with something like number of lines changed. Most of them will be small.

[ Parent | on HN ]
Re:Improving code review time at Meta by pavon on Thursday November 17, 2022 @10:14PM (#33649564)
When I'm on a break, I'm pretty much always mulling my task on the back of my mind, and doing things that don't require concentration, so when I get back from the break I'm still in the same frame of mind. Doing code reviews definitely forces a sharper shift of mind and takes longer to switch back from than a break does. Sometimes it is worthwhile, but it does have a cost.
[ Parent | on HN ]