TODO
Snapshotting (Fork and Write) is not perfect, right now we simply block requests while memory is dumped on disk. We are working on a solution that will give us better performance. An update will be released soon.(You know, I could rewrite Redis in less than 146,000 lines of code...)
What then, all this effort for basically nothing except a fork, which you then have to continue maintaining etc.
I wouldn't expect anyone to accept the patch in this state, but I hope that the "who cares about Windows" attitude dies and a dialog to get proper support into redis is started.
It's a shame that we're using an unofficial version on that platform right now.
I would imagine they have activated "Compile as C++" for certain files. VC++ doesn't support C99, and it's probably easier to fix up any C++ incompatibilities than try to C89-ize everything.
My answer (obviously) is "yes", although as some folks point out here too, there are portability concerns that make it worth it sometimes.
It's mostly a habit people pick up from C++ (where it's mandatory due to stricter typing), and if you want to build C code with a C++ compiler, you need to add the casts.
Given Microsoft's C++ fetish, I'm unsurprised by this.
Does Redis still do that thing where it forks and the child writes its core to disk? How does that work under Windows, which doesn't have fork?
Finally, this is one big patch:
With many of the changes along the lines of: or Eliminating compiler warnings is nice and whatever, but probably not the best thing to include in your "add major feature" patch.