News for hackers. Stuff that matters.
Re:Eglot has landed on master: Emacs now has a built-in LSP ... by tptacek on Sunday October 23, 2022 @12:40PM (#33308240)
Presumably eglot was picked because it's by far the more emacsy LSP client. It does most of its user-visible job by integrating with other built-in packages, like Flymake, ElDoc, project.el, and most importantly xref. Integrating lsp-mode would make much less sense, since you'd be integrating an alternative universe of packages that already have built-in analogs.
Re:Eglot has landed on master: Emacs now has a built-in LSP ... by ghosty141 on Sunday October 23, 2022 @01:02PM (#33308418)
Flymake is my biggest gripe with eglot. Sadly you cant really switch it out with flycheck
Re:Eglot has landed on master: Emacs now has a built-in LSP ... by tptacek on Sunday October 23, 2022 @01:46PM (#33308732)
I thought this would annoy me, since I had a custom flycheck setup for years and years prior to eglot, but I haven't noticed any differences in my workflow; it just works.
Re:Eglot has landed on master: Emacs now has a built-in LSP ... by morelisp on Sunday October 23, 2022 @01:56PM (#33308821)
Was `flycheck-list-errors` not part of your workflow, or do you have a decent replacement for it? Its lack is my one gripe with flymake.
Re:Eglot has landed on master: Emacs now has a built-in LSP ... by mickeyp on Sunday October 23, 2022 @02:18PM (#33308979)
Have you tried `M-x flymake-show-project-diagnostics'?
Re:Eglot has landed on master: Emacs now has a built-in LSP ... by morelisp on Sunday October 23, 2022 @02:44PM (#33309145)
Yes; as far as I can tell it runs afoul of unresolvable project.el incompatibilities unless you're using at least Emacs 28.
Re:Eglot has landed on master: Emacs now has a built-in LSP ... by BaculumMeumEst on Sunday October 23, 2022 @03:13PM (#33309384)
It seems odd to complain about an issue that doesn’t exist in the latest stable version.
Re:Eglot has landed on master: Emacs now has a built-in LSP ... by morelisp on Sunday October 23, 2022 @03:21PM (#33309455)
It's been an issue since before it was the latest stable version, and if the packages needed that version they should be declaring dependencies on it. And project.el is still today marked experimental, so this will probably happen again.

Version management in Emacs is hard but a) lots of the community runs Emacs versions much older than 1y old and at least few years of compatibility is (used to be?) a strong cultural norm, b) it's common to offer fallbacks to e.g. `locate-dominating-file` or similar primitive cases especially when using relatively new features, c) I don't think project.el is very good in general.

Re:Eglot has landed on master: Emacs now has a built-in LSP ... by josteink on Sunday October 23, 2022 @03:20PM (#33309453)
Some people run Emacs from their local system package-managers instead of building from source.

They will be stuck on older versions and experience those problems as current problems.

Re:Eglot has landed on master: Emacs now has a built-in LSP ... by anyfoo on Sunday October 23, 2022 @02:28PM (#33309043)
Are you sure? I could have sworn my lsp-mode uses at least flymake, xref, and projectile (which I use over project.el) as well, and I don’t remember making a custom setup in that regard? Not in front of emacs right now, but very sure. Maybe that was different in the past?

I switched from eglot back to lsp-mode a while ago, but I don’t quite remember why unfortunately. I think lsp-mode “did more” or something like that, and seemed to have changed for the better.

Re:Eglot has landed on master: Emacs now has a built-in LSP ... by tptacek on Sunday October 23, 2022 @03:09PM (#33309349)
I just remember a zillion weird popups with lsp-mode, which is all UI that isn't built in to Emacs. But also: Projectile isn't built into Emacs. Project.el is. The lsp-mode hovers are bespoke; eglot just uses ElDoc. lsp-mode wants you to use flycheck; flycheck isn't built into Emacs. lsp-mode can use xref, but it also has its own thing. lsp-mode has its own header and modeline goo. It goes on like that.

None of this is bad. These aren't critiques of lsp-mode. But they're definitely reasons why it would make sense to integrate Eglot, which prioritizes integrating with Emacs built-in libraries.

The actual critique of lsp-mode I would make is that I bounced from lsp-mode at least 3 times trying to get things working, and things would always be ok for like a couple days and then I'd lose 30 minutes to debugging and ultimately just turn it all off so I could get on with my day. I enabled Eglot once, with like 10 lines of use-package, and haven't touched it since.

Re:Eglot has landed on master: Emacs now has a built-in LSP ... by anyfoo on Sunday October 23, 2022 @03:26PM (#33309500)
Sorry, I’m just not sure most of that is true anymore. How long ago was your experience? I remember bouncing off lsp-mode into eglot years ago as well for similar reasons, but nowadays it just seems totally different to me.

I’ve never used anything but xref in lsp-mode, I rely on xref a lot. I wasn’t even aware that lsp-mode has, or had, something bespoke there.

I use flymake, not flycheck, I don’t think I had to configure that.

projectile is just my personal preference because I'm used to it, the manual says it integrates with either project.el or projectile.

I remember the weird popups you mention from my first lsp-mode trial. I don’t know where they’re gone, nowadays it’s just text in the buffer. (But I don’t know whether that’s ElDoc or not.)

Re:Eglot has landed on master: Emacs now has a built-in LSP ... by josteink on Sunday October 23, 2022 @03:19PM (#33309438)
> I just remember a zillion weird popups with lsp-mode

I think that may be lsp-ui, not lsp-mode, but I might be mistaken.

Re:Eglot has landed on master: Emacs now has a built-in LSP ... by Myrmornis on Sunday October 23, 2022 @04:31PM (#33309994)
Yes I had exactly the same experience, maybe 3 years ago? Installing lsp-mode resulted in an overblown UI with all sorts of gadgets; it looked like an attempt to create an "IDE experience" in Emacs, and so I ran away, used eglot for a few months, and then ended my 20-year Emacs run and switched to VSCode. (Apart from magit -- of course I do still have an Emacs instance running.) But it does sound like people are saying that lsp-mode got rid of the tasteless stuff. And since Eglot development has now moved away from GitHub to a combination of unpleasant mailing lists and unfashionable issue-tracking apps, I wonder whether it will stand a chance in the future competition.
Re:Eglot has landed on master: Emacs now has a built-in LSP ... by solomatov on Sunday October 23, 2022 @10:17PM (#33312315)
There's a magit like extension for vscode: https://marketplace.visualstudio.com/items?itemName=kahole.m...