News for hackers. Stuff that matters.
Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by gw99 on Thursday October 13, 2022 @04:59PM (#33196420)
Oh yes this. It's so easy to critically fuck up an invite into an organisation. If you get typo the username you are potentially compromised. I've seen a couple of near misses on this already.

Note: the invite input box actually autocompletes ALL github usernames.

Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by ccakes on Thursday October 13, 2022 @05:23PM (#33196675)
You can invite by email addr, so the workaround here is only invite corporate email addresses.

If the target user hasn't added their corp email to their profile then they can't be part of the org.

Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by prepend on Thursday October 13, 2022 @06:07PM (#33197081)
This is what I do but I really wish there was a better integration with auth providers and could use it for the invite. Would be nice to search my directory to type the email and confirm the name matches the email.

This is what GitLab does with their hosted AD/LDAP connector.

I’m in fear of mistyping something and inviting the wrong person.

Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by dotancohen on Thursday October 13, 2022 @06:27PM (#33197293)
So never type an email address in at all. Go to an extent email message, copy the bloke's email address, then paste it into the Github interface.
Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by EE84M3i on Thursday October 13, 2022 @08:05PM (#33198115)
This can be vulnerable to "ticket trick" - often support/helpdesk sites are put on the main domain and have reply-to email addresses that will reflect the content back to the user requesting support. This can be used to sign up for slack, etc.
Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by matai_kolila on Thursday October 13, 2022 @05:03PM (#33196462)
> Note: the invite input box actually autocompletes ALL github usernames.

I'm sorry, but that's wild. That's like, not even an easy engineering problem to solve necessarily, given their size!

Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by gw99 on Thursday October 13, 2022 @05:16PM (#33196596)
Not really. They only have 83-90 million users. That's not really a big table, at least in my world...
Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by matai_kolila on Thursday October 13, 2022 @06:05PM (#33197060)
In my world 20 is a lot because finding customers is hard... :(
Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by count on Thursday October 13, 2022 @09:46PM (#33198725)
It blew my mind after upgrading to enterprise that was still how it worked.
Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by kuschku on Friday October 14, 2022 @05:01AM (#33201215)
Sorry, but string prefix search over a few hundred million entries is something you can do with the same performance using just postgres on a single server with just a few hours of dev time.

I've done it before, it's not as impressive as it seems.

With trigrams you can even do precise substring search on this scale with good performance.

If you'd like, I can build a small demo.

Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by matai_kolila on Friday October 14, 2022 @02:46PM (#33207343)
Lol no thanks, once you hit the server I’m good, it’s more about the UI for me.
Re:Toyota Accidently Exposed a Secret Key Publicly on GitHub... by hrez on Friday October 14, 2022 @03:02PM (#33207524)
Org can be configured with SSO which would require Org members to login with your Co auth in order to access the Org.

Though it would still allow "collaborators" which don't have SSO requirement.