News for hackers. Stuff that matters.
Re:Why public chats are better than direct messages by kaashif on Friday September 09, 2022 @07:34AM (#32777925)
Most actionable code review comments are criticism. People have to be able to avoid taking criticism of their code personally, and to write criticism in an inoffensive way.

The whole team should be able to look at and learn from code reviews, and the best way to do that is if it's in the open for the whole team or company to see. I'm not sure if truly "public" is possible for most companies, so I'm not talking about that.

I would say that you're right about other kinds of feedback, like criticism about (mis)conduct, attitude, etc. That should for sure be done in private.

There are no comments on this comment yet.