Re:Integers in C quiz
by tialaramex on Sunday September 04, 2022 @01:55PM
(#32715724)
extern volatile uint64_t *reg;
*reg &= ~x;
People should stop doing this. What this means is: extern volatile uint64_t *reg;
uint64_t tmp = *reg;
tmp &= ~x;
*reg = temp;
But of course when you write that chances are somebody will point out that you're running in interruptible context sometimes in this function, so that's actually introducing a race condition. Why didn't they say so when you wrote it your way? Because that looked like a single operation and so it wasn't obvious it might get interrupted.I don’t find that very convincing. It’s simply ambiguous, I might want this:
*reg &= ~(uint64_t)x;
or, and there’s no elegant way to even write this in C, I might want: *reg &=(uint64_t)(uint8_t)~x;
The fact that I have to write two casts here to undo the damage of the auto-promotion is evidence of how broken this is.
If it promoted to unsigned int, then it would also clear bits 32-63.