I get what you're saying, but golf courses usually take up a lot of space that is used by a proportionally smaller group of people. Those other things you mention can be enjoyed by many many more people in a much denser fashion.

I definitely agree that golf courses are inefficient uses of land, but even if we built mid-density housing on all of them here, it wouldn't solve the problem. There are plenty of other low-density areas that need to be upzoned if we're going to solve anything.