Re:In Praise of Stacked PRs
by chrisweekly on Sunday July 24, 2022 @01:19PM
(#32215566)
That's interesting, explicitly to require that bugs be reproduced in CI. It makes sense in theory, but in praxis (IME) CI systems tend to be overtaxed / underprovisioned - meaning this extra burden might be questionable. /$.02
Given the cost a typical CI system vs the salary cost of a typical dev, the business case should be fairly easy that devs always should have CI capacity available.
The same burden is present when splitting the two commits into two PRs.
Re:In Praise of Stacked PRs
by chrisweekly on Monday July 25, 2022 @02:40PM
(#32229007)
Actually no, the burden I referred to was -- unrelated to stacked vs serial PRs -- specifically the GP's practice of requiring that tests fail in CI.
"rule that there must be 1 commit just introducing a test that fails on CI for bugfix PRs"
We actually have a rule that there must be 1 commit just introducing a test that fails on CI for bugfix PRs.