You know that you can edit the history in order to fold the small fixes and mistakes back into the commit they belong to right? It’s not an all or nothing situation.
> If someone wants to dig into a feature commit by commit, they can typically check the PR out and do it that way, but in practice, I've rarely seen that happen
Of course not, it’s a pain in the ass having to go back to the PR and trawl through a commits sequence you describe as essentially broken.
Re:Commit Messages Don’t Matter
by afterburner5 on Saturday July 23, 2022 @04:40AM
(#32201519)
I know that, but what advantage do you get from trawling through a commit sequence, over the general feature with proper documentation? If you can't understand how the overall feature was implemented, that PR generally speaking is lacking enough context to be reviewed, so why did it get merged in?
Re:Commit Messages Don’t Matter
by staticassertion on Friday July 22, 2022 @01:56PM
(#32195040)
Does anyone actually review PRs commit by commit?
When the history is designed for that, sure. Although having the review tool also designed for it makes this much more convenient and comfortable.
Github, sadly, very much is not designed for that.
I tend not to worry about that and generally just squash the commits when I merge, so that, on main, there's a single commit for a particular feature. That's an overall piece of work I did. If someone wants to dig into a feature commit by commit, they can typically check the PR out and do it that way, but in practice, I've rarely seen that happen, and if it did, it was more for the overall feature rather than any one commit.
So, overall, it's not that commit messages don't matter, but rather that, while a pristine history is always nice to see, it's not always possible without unnecessary head scratching that generally just costs more dev time for very little benefit.