News for hackers. Stuff that matters.
Re:Ask HN: How do you keep code reviews from taking forever? by oshirisuki on Tuesday July 12, 2022 @02:31PM (#32073949)
you and your team must consider merging to master (or whatever your production branch is called) the important thing, not pushing in isolation, though this only works if review blocks merging to that branch

this way, it stops being "I reviewed PRs" and becomes "we [the team] merged N commits to master"

in my previous team, I got into the habit of doing code review first thing in the morning, and right before the end of day, so others could either start by checking my review comments, or merge at or near the beginning of the day

it helps if commits are very small

There are no comments on this comment yet.