News for hackers. Stuff that matters.

A comment on Some Assembly Required: An approachable introduction to assembly. Parent comment

Re:Some Assembly Required: An approachable introduction to a... by darkgray on Tuesday June 28, 2022 @02:58PM (#31911643)
It's a bit more involved than that.

  mul rcx, rax       ; multiply our result by our base, save into rcx
This should probably be using rbx, since that's the designated base, not rax, which is the exponent.

In the explanation just above, there's a 2*8 step missing, while this one is incorrect:

  4. result = 16 * 2, result is now 16
Since 2*16 is not 16.
[ Parent | on HN ]
Re:Some Assembly Required: An approachable introduction to a... by jessicard on Tuesday June 28, 2022 @03:00PM (#31911665)
Ahhhhh thank you! Do you mind opening a PR or issue so I can get to that? Thank you for noticing!!
[ Parent | on HN ]