News for hackers. Stuff that matters.
Re:Ask HN: What tone to use in code review suggestions? by SilasX on Monday June 27, 2022 @11:34PM (#31903772)
That’s the point: the replies are saying that the content is more of an issue than the tone, and so OP should focus on the hints for the former.
Re:Ask HN: What tone to use in code review suggestions? by osigurdson on Tuesday June 28, 2022 @12:32AM (#31904099)
How do we know the OP had any issues coming up with valuable and insightful comments? Tone can have an impact - being particularly rude is not likely to result in good outcomes (but maybe it could in some situations). Why aren't we exploring what was originally asked?
Re:Ask HN: What tone to use in code review suggestions? by SilasX on Tuesday June 28, 2022 @11:30AM (#31908999)
Because all of the versions have the same problem regardless of tone. If the assumptions are in error and the OP had been leaving off the justifications suggested, they can reply and say so! (But, as it turns out, didn’t.)