News for hackers. Stuff that matters.
Re:Ask HN: What tone to use in code review suggestions? by lloeki on Monday June 27, 2022 @04:12PM (#31900137)
> "Why did you do it this way?"

While the question is literally (and without any other thought) what I have sometimes in mind, usually I ask something like:

I feel I might be missing some insight or context, could you walk me through your rationale?

Because if I don't get some code change I may very well be missing something. And in any case by talking we're only going to improve our mutual understanding, both of the codebase and of each other's thought process.

There are no comments on this comment yet.